Skip to content

Commit 8495c61

Browse files
committed
Fix filter chips
1 parent 3ebaae7 commit 8495c61

File tree

5 files changed

+23
-21
lines changed

5 files changed

+23
-21
lines changed

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/FilterChip.kt

+20-18
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,12 @@
11
package net.mullvad.mullvadvpn.compose.component
22

33
import androidx.compose.foundation.clickable
4-
import androidx.compose.foundation.layout.Spacer
54
import androidx.compose.foundation.layout.padding
65
import androidx.compose.foundation.layout.size
7-
import androidx.compose.material3.ButtonDefaults
86
import androidx.compose.material3.FilterChip
97
import androidx.compose.material3.FilterChipDefaults
108
import androidx.compose.material3.Icon
9+
import androidx.compose.material3.InputChip
1110
import androidx.compose.material3.MaterialTheme
1211
import androidx.compose.material3.Text
1312
import androidx.compose.runtime.Composable
@@ -33,33 +32,36 @@ private fun PreviewMullvadFilterChip() {
3332
}
3433

3534
@Composable
36-
fun MullvadFilterChip(text: String, onRemoveClick: () -> Unit) {
37-
FilterChip(
38-
modifier = Modifier.padding(vertical = Dimens.chipVerticalPadding),
35+
fun MullvadFilterChip(
36+
containerColor: Color = MaterialTheme.colorScheme.primary,
37+
borderColor: Color = Color.Transparent,
38+
labelColor: Color = MaterialTheme.colorScheme.onPrimary,
39+
iconColor: Color = MaterialTheme.colorScheme.onPrimary,
40+
text: String,
41+
onRemoveClick: () -> Unit
42+
) {
43+
InputChip(
3944
shape = MaterialTheme.shapes.chipShape,
4045
colors =
41-
FilterChipDefaults.filterChipColors(containerColor = MaterialTheme.colorScheme.primary),
46+
FilterChipDefaults.filterChipColors(
47+
containerColor = containerColor,
48+
labelColor = labelColor,
49+
iconColor = iconColor
50+
),
4251
border =
4352
FilterChipDefaults.filterChipBorder(
44-
borderColor = Color.Transparent,
45-
disabledBorderColor = Color.Transparent,
53+
borderColor = borderColor,
4654
enabled = true,
4755
selected = false
4856
),
4957
selected = false,
50-
onClick = {},
51-
label = {
52-
Text(
53-
text = text,
54-
color = MaterialTheme.colorScheme.onPrimary,
55-
style = MaterialTheme.typography.labelMedium
56-
)
57-
Spacer(modifier = Modifier.size(ButtonDefaults.IconSpacing))
58+
onClick = onRemoveClick,
59+
label = { Text(text = text, style = MaterialTheme.typography.labelMedium) },
60+
trailingIcon = {
5861
Icon(
5962
painter = painterResource(id = R.drawable.icon_close),
6063
contentDescription = null,
61-
tint = MaterialTheme.colorScheme.onPrimary,
62-
modifier = Modifier.size(Dimens.smallIconSize).clickable { onRemoveClick() }
64+
modifier = Modifier.size(Dimens.smallIconSize)
6365
)
6466
}
6567
)

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/ServerIpOverridesScreen.kt

+1
Original file line numberDiff line numberDiff line change
@@ -231,6 +231,7 @@ private fun ImportOverridesByBottomSheet(
231231
}
232232
}
233233
}
234+
Color.Red
234235
val backgroundColor: Color = MaterialTheme.colorScheme.surfaceContainer
235236
val onBackgroundColor: Color = MaterialTheme.colorScheme.onSurface
236237

android/lib/resource/src/main/res/drawable/icon_back.xml

-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
<path android:pathData="M12,24C5.3731,24 -0,18.6269 -0,12C-0,5.3731 5.3731,0 12,0C18.6269,0 24,5.3731 24,12C24,18.6269 18.6269,24 12,24ZM7.0055,11.9979C6.9755,12.2732 7.0685,12.5604 7.2852,12.7774L13.2129,18.7118C13.5936,19.0929 14.2231,19.0908 14.6233,18.7027L14.6942,18.634C15.0925,18.2478 15.1055,17.6196 14.7109,17.218L9.5805,11.9979L14.7109,6.7777C15.1055,6.3762 15.0925,5.7479 14.6942,5.3618L14.6233,5.293C14.2231,4.9049 13.5936,4.9028 13.2129,5.2839L7.2852,11.2184C7.0685,11.4353 6.9755,11.7225 7.0055,11.9979L7.0055,11.9979Z"
77
android:strokeWidth="1"
88
android:fillColor="#FFFFFF"
9-
android:fillAlpha="0.6"
109
android:fillType="evenOdd"
1110
android:strokeColor="#00000000" />
1211
</vector>

android/lib/resource/src/main/res/drawable/icon_close.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
android:height="24dp"
55
android:viewportWidth="24.0"
66
android:viewportHeight="24.0">
7-
<path android:fillColor="#99FFFFFF"
7+
<path android:fillColor="#FFFFFFFF"
88
android:pathData="
99
M 12,24
1010
C 5.37312,24 0,18.62688 0,12

android/lib/resource/src/main/res/drawable/icons_more_circle.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
android:height="24dp"
44
android:viewportWidth="24.0"
55
android:viewportHeight="24.0">
6-
<path android:fillAlpha="0.6"
6+
<path
77
android:fillColor="#FFFFFF"
88
android:fillType="evenOdd"
99
android:pathData="M12,24A12,12 0,0 1,3.515 3.515a12,12 0,1 1,16.97 16.97A11.922,11.922 0,0 1,12 24zM10.445,16.044L10.445,17.6h3.111v-1.556zM7.333,12.155v1.556h9.333v-1.556zM5,8.267v1.556h14L19,8.267z"

0 commit comments

Comments
 (0)