Remove error case from custom list location screen

Author: Pururun

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/CustomListLocationsScreen.kt

@@ -95,26 +95,16 @@ fun CustomListLocations(
         }
     }
 
-    val snackbarHostState = remember { SnackbarHostState() }
-    val context: Context = LocalContext.current
     LaunchedEffectCollect(customListsViewModel.uiSideEffect) { sideEffect ->
         when (sideEffect) {
             is CustomListLocationsSideEffect.ReturnWithResultData ->
                 backNavigator.navigateBack(result = sideEffect.result)
-            CustomListLocationsSideEffect.Error ->
-                launch {
-                    snackbarHostState.showSnackbarImmediately(
-                        message = context.getString(R.string.error_occurred),
-                        duration = SnackbarDuration.Short
-                    )
-                }
         }
     }
 
     val state by customListsViewModel.uiState.collectAsStateWithLifecycle()
     CustomListLocationsScreen(
         state = state,
-        snackbarHostState = snackbarHostState,
         onSearchTermInput = customListsViewModel::onSearchTermInput,
         onSaveClick = customListsViewModel::save,
         onRelaySelectionClick = customListsViewModel::onRelaySelectionClick,
@@ -133,15 +123,13 @@ fun CustomListLocations(
 @Composable
 fun CustomListLocationsScreen(
     state: CustomListLocationsUiState,
-    snackbarHostState: SnackbarHostState = SnackbarHostState(),
     onSearchTermInput: (String) -> Unit = {},
     onSaveClick: () -> Unit = {},
     onRelaySelectionClick: (RelayItem.Location, selected: Boolean) -> Unit = { _, _ -> },
     onExpand: (RelayItem.Location, selected: Boolean) -> Unit = { _, _ -> },
     onBackClick: () -> Unit = {}
 ) {
     ScaffoldWithSmallTopBar(
-        snackbarHostState = snackbarHostState,
         appBarTitle =
             stringResource(
                 if (state.newList) {

android/app/src/main/kotlin/net/mullvad/mullvadvpn/viewmodel/CustomListLocationsViewModel.kt

@@ -116,7 +116,13 @@ class CustomListLocationsViewModel(
                         )
                     )
                     .fold(
-                        { _uiSideEffect.tryEmit(CustomListLocationsSideEffect.Error) },
+                        {
+                            _uiSideEffect.tryEmit(
+                                CustomListLocationsSideEffect.ReturnWithResultData(
+                                    CustomListActionResultData.GenericError
+                                )
+                            )
+                        },
                         { result ->
                             val resultData =
                                 if (navArgs.newList) {
@@ -315,8 +321,6 @@ class CustomListLocationsViewModel(
 }
 
 sealed interface CustomListLocationsSideEffect {
-    data class ReturnWithResultData(val result: CustomListActionResultData.Success) :
+    data class ReturnWithResultData(val result: CustomListActionResultData) :
         CustomListLocationsSideEffect
-
-    data object Error : CustomListLocationsSideEffect
 }