Skip to content

Commit 9b86bcb

Browse files
Jon Peterssonbuggmagnet
Jon Petersson
authored andcommitted
Allow users to import settings by pasting JSON blobs
1 parent 15b5cb5 commit 9b86bcb

17 files changed

+796
-29
lines changed

ios/MullvadSettings/IPOverride.swift

+55
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,55 @@
1+
//
2+
// IPOverride.swift
3+
// MullvadVPN
4+
//
5+
// Created by Jon Petersson on 2024-01-16.
6+
// Copyright © 2024 Mullvad VPN AB. All rights reserved.
7+
//
8+
9+
import Network
10+
11+
public struct RelayOverrides: Codable {
12+
public let overrides: [IPOverride]
13+
14+
private enum CodingKeys: String, CodingKey {
15+
case overrides = "relay_overrides"
16+
}
17+
}
18+
19+
public struct IPOverride: Codable, Equatable {
20+
public let hostname: String
21+
public var ipv4Address: IPv4Address?
22+
public var ipv6Address: IPv6Address?
23+
24+
private enum CodingKeys: String, CodingKey {
25+
case hostname
26+
case ipv4Address = "ipv4_addr_in"
27+
case ipv6Address = "ipv6_addr_in"
28+
}
29+
30+
init(hostname: String, ipv4Address: IPv4Address?, ipv6Address: IPv6Address?) throws {
31+
self.hostname = hostname
32+
self.ipv4Address = ipv4Address
33+
self.ipv6Address = ipv6Address
34+
35+
if self.ipv4Address.isNil && self.ipv6Address.isNil {
36+
throw IPOverrideFormatError(errorDescription: "ipv4Address and ipv6Address cannot both be nil.")
37+
}
38+
}
39+
40+
public init(from decoder: Decoder) throws {
41+
let container = try decoder.container(keyedBy: CodingKeys.self)
42+
43+
self.hostname = try container.decode(String.self, forKey: .hostname)
44+
self.ipv4Address = try container.decodeIfPresent(IPv4Address.self, forKey: .ipv4Address)
45+
self.ipv6Address = try container.decodeIfPresent(IPv6Address.self, forKey: .ipv6Address)
46+
47+
if self.ipv4Address.isNil && self.ipv6Address.isNil {
48+
throw IPOverrideFormatError(errorDescription: "ipv4Address and ipv6Address cannot both be nil.")
49+
}
50+
}
51+
}
52+
53+
public struct IPOverrideFormatError: LocalizedError {
54+
public let errorDescription: String?
55+
}
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,93 @@
1+
//
2+
// IPOverrideRepository.swift
3+
// MullvadVPN
4+
//
5+
// Created by Jon Petersson on 2024-01-16.
6+
// Copyright © 2024 Mullvad VPN AB. All rights reserved.
7+
//
8+
9+
import Foundation
10+
import MullvadLogging
11+
12+
public protocol IPOverrideRepositoryProtocol {
13+
func add(_ overrides: [IPOverride])
14+
func fetchAll() -> [IPOverride]
15+
func fetchByHostname(_ hostname: String) -> IPOverride?
16+
func deleteAll()
17+
func parse(data: Data) throws -> [IPOverride]
18+
}
19+
20+
public class IPOverrideRepository: IPOverrideRepositoryProtocol {
21+
private let logger = Logger(label: "IPOverrideRepository")
22+
23+
public init() {}
24+
25+
public func add(_ overrides: [IPOverride]) {
26+
var storedOverrides = fetchAll()
27+
28+
overrides.forEach { override in
29+
if let existingOverrideIndex = storedOverrides.firstIndex(where: { $0.hostname == override.hostname }) {
30+
var existingOverride = storedOverrides[existingOverrideIndex]
31+
32+
if let ipv4Address = override.ipv4Address {
33+
existingOverride.ipv4Address = ipv4Address
34+
}
35+
36+
if let ipv6Address = override.ipv6Address {
37+
existingOverride.ipv6Address = ipv6Address
38+
}
39+
40+
storedOverrides[existingOverrideIndex] = existingOverride
41+
} else {
42+
storedOverrides.append(override)
43+
}
44+
}
45+
46+
do {
47+
try writeIpOverrides(storedOverrides)
48+
} catch {
49+
logger.error("Could not add override(s): \(overrides) \nError: \(error)")
50+
}
51+
}
52+
53+
public func fetchAll() -> [IPOverride] {
54+
return (try? readIpOverrides()) ?? []
55+
}
56+
57+
public func fetchByHostname(_ hostname: String) -> IPOverride? {
58+
return fetchAll().first { $0.hostname == hostname }
59+
}
60+
61+
public func deleteAll() {
62+
do {
63+
try SettingsManager.store.delete(key: .ipOverrides)
64+
} catch {
65+
logger.error("Could not delete all overrides. \nError: \(error)")
66+
}
67+
}
68+
69+
public func parse(data: Data) throws -> [IPOverride] {
70+
let decoder = JSONDecoder()
71+
let jsonData = try decoder.decode(RelayOverrides.self, from: data)
72+
73+
return jsonData.overrides
74+
}
75+
76+
private func readIpOverrides() throws -> [IPOverride] {
77+
let parser = makeParser()
78+
let data = try SettingsManager.store.read(key: .ipOverrides)
79+
80+
return try parser.parseUnversionedPayload(as: [IPOverride].self, from: data)
81+
}
82+
83+
private func writeIpOverrides(_ overrides: [IPOverride]) throws {
84+
let parser = makeParser()
85+
let data = try parser.produceUnversionedPayload(overrides)
86+
87+
try SettingsManager.store.write(data, for: .ipOverrides)
88+
}
89+
90+
private func makeParser() -> SettingsParser {
91+
SettingsParser(decoder: JSONDecoder(), encoder: JSONEncoder())
92+
}
93+
}

ios/MullvadSettings/SettingsStore.swift

+1
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ public enum SettingsKey: String, CaseIterable {
1212
case settings = "Settings"
1313
case deviceState = "DeviceState"
1414
case apiAccessMethods = "ApiAccessMethods"
15+
case ipOverrides = "IPOverrides"
1516
case lastUsedAccount = "LastUsedAccount"
1617
case shouldWipeSettings = "ShouldWipeSettings"
1718
}

0 commit comments

Comments
 (0)