Skip to content

Commit a0cc830

Browse files
committed
Fix unit tests
1 parent 4c23f35 commit a0cc830

File tree

1 file changed

+10
-5
lines changed

1 file changed

+10
-5
lines changed

android/app/src/test/kotlin/net/mullvad/mullvadvpn/viewmodel/ChangelogViewModelTest.kt android/app/src/test/kotlin/net/mullvad/mullvadvpn/viewmodel/MullvadAppViewModelTest.kt

+10-5
Original file line numberDiff line numberDiff line change
@@ -11,18 +11,20 @@ import kotlin.test.assertEquals
1111
import kotlinx.coroutines.test.runTest
1212
import net.mullvad.mullvadvpn.lib.common.test.TestCoroutineRule
1313
import net.mullvad.mullvadvpn.lib.model.BuildVersion
14+
import net.mullvad.mullvadvpn.lib.shared.ConnectionProxy
1415
import net.mullvad.mullvadvpn.repository.ChangelogRepository
1516
import org.junit.jupiter.api.AfterEach
1617
import org.junit.jupiter.api.BeforeEach
1718
import org.junit.jupiter.api.Test
1819
import org.junit.jupiter.api.extension.ExtendWith
1920

2021
@ExtendWith(TestCoroutineRule::class)
21-
class ChangelogViewModelTest {
22+
class MullvadAppViewModelTest {
2223

2324
@MockK private lateinit var mockedChangelogRepository: ChangelogRepository
25+
@MockK private lateinit var connectionProxy: ConnectionProxy
2426

25-
private lateinit var viewModel: ChangelogViewModel
27+
private lateinit var viewModel: MullvadAppViewModel
2628

2729
private val buildVersion = BuildVersion("1.0", 10)
2830

@@ -43,7 +45,8 @@ class ChangelogViewModelTest {
4345
// Arrange
4446
every { mockedChangelogRepository.getVersionCodeOfMostRecentChangelogShowed() } returns
4547
buildVersion.code
46-
viewModel = ChangelogViewModel(mockedChangelogRepository, buildVersion, false)
48+
viewModel =
49+
MullvadAppViewModel(mockedChangelogRepository, connectionProxy, buildVersion, false)
4750

4851
// If we have the most up to date version code, we should not show the changelog dialog
4952
viewModel.uiSideEffect.test { expectNoEvents() }
@@ -58,7 +61,8 @@ class ChangelogViewModelTest {
5861
version
5962
every { mockedChangelogRepository.getLastVersionChanges() } returns changes
6063

61-
viewModel = ChangelogViewModel(mockedChangelogRepository, buildVersion, false)
64+
viewModel =
65+
MullvadAppViewModel(mockedChangelogRepository, connectionProxy, buildVersion, false)
6266
// Given a new version with a change log we should return it
6367
viewModel.uiSideEffect.test {
6468
assertEquals(awaitItem(), Changelog(version = buildVersion.name, changes = changes))
@@ -71,7 +75,8 @@ class ChangelogViewModelTest {
7175
every { mockedChangelogRepository.getVersionCodeOfMostRecentChangelogShowed() } returns -1
7276
every { mockedChangelogRepository.getLastVersionChanges() } returns emptyList()
7377

74-
viewModel = ChangelogViewModel(mockedChangelogRepository, buildVersion, false)
78+
viewModel =
79+
MullvadAppViewModel(mockedChangelogRepository, connectionProxy, buildVersion, false)
7580
// Given a new version with a change log we should not return it
7681
viewModel.uiSideEffect.test { expectNoEvents() }
7782
}

0 commit comments

Comments
 (0)