Skip to content

Commit aeb5072

Browse files
Handle tunnel_protocol now being a required message field
1 parent 1ec0cd9 commit aeb5072

File tree

1 file changed

+3
-13
lines changed

1 file changed

+3
-13
lines changed

mullvad-management-interface/src/types/conversions/relay_constraints.rs

+3-13
Original file line numberDiff line numberDiff line change
@@ -97,13 +97,8 @@ impl TryFrom<proto::RelaySettings> for mullvad_types::relay_constraints::RelaySe
9797
.unwrap_or(Constraint::Any);
9898
let providers = try_providers_constraint_from_proto(&settings.providers)?;
9999
let ownership = try_ownership_constraint_from_i32(settings.ownership)?;
100-
let tunnel_protocol = settings
101-
.tunnel_type
102-
.map(try_tunnel_type_from_i32)
103-
.transpose()?
104-
.ok_or(FromProtobufTypeError::InvalidArgument(
105-
"missing tunnel protocol",
106-
))?;
100+
let tunnel_protocol = try_tunnel_type_from_i32(settings.tunnel_type)?;
101+
107102
let openvpn_constraints =
108103
mullvad_constraints::OpenVpnConstraints::try_from(
109104
&settings.openvpn_constraints.ok_or(
@@ -227,7 +222,6 @@ impl From<mullvad_types::relay_constraints::RelaySettings> for proto::RelaySetti
227222
fn from(settings: mullvad_types::relay_constraints::RelaySettings) -> Self {
228223
use mullvad_types::relay_constraints::RelaySettings as MullvadRelaySettings;
229224
use proto::relay_settings;
230-
use talpid_types::net as talpid_net;
231225

232226
let endpoint = match settings {
233227
MullvadRelaySettings::CustomTunnelEndpoint(endpoint) => {
@@ -244,11 +238,7 @@ impl From<mullvad_types::relay_constraints::RelaySettings> for proto::RelaySetti
244238
.map(proto::LocationConstraint::from),
245239
providers: convert_providers_constraint(&constraints.providers),
246240
ownership: convert_ownership_constraint(&constraints.ownership) as i32,
247-
tunnel_type: match constraints.tunnel_protocol {
248-
talpid_net::TunnelType::Wireguard => Some(proto::TunnelType::Wireguard),
249-
talpid_net::TunnelType::OpenVpn => Some(proto::TunnelType::Openvpn),
250-
}
251-
.map(i32::from),
241+
tunnel_type: constraints.tunnel_protocol as i32,
252242

253243
wireguard_constraints: Some(proto::WireguardConstraints {
254244
port: constraints

0 commit comments

Comments
 (0)