Apply filtering on custom lists

Author: mojganii

ios/MullvadVPN/View controllers/SelectLocation/CustomListsDataSource.swift

@@ -25,16 +25,18 @@ class CustomListsDataSource: LocationDataSourceProtocol {
 
     /// Constructs a collection of node trees by copying each matching counterpart
     /// from the complete list of nodes created in ``AllLocationDataSource``.
-    func reload(allLocationNodes: [LocationNode]) {
-        nodes = repository.fetchAll().map { list in
+    func reload(allLocationNodes: [LocationNode], isFiltered: Bool) {
+        nodes.removeAll()
+        let customLists = repository.fetchAll()
+        for customList in customLists {
             let listNode = CustomListLocationNode(
-                name: list.name,
-                code: list.name.lowercased(),
-                locations: list.locations,
-                customList: list
+                name: customList.name,
+                code: customList.name.lowercased(),
+                locations: customList.locations,
+                customList: customList
             )
 
-            listNode.children = list.locations.compactMap { location in
+            listNode.children = customList.locations.compactMap { location in
                 copy(location, from: allLocationNodes, withParent: listNode)
             }
 
@@ -46,7 +48,15 @@ class CustomListsDataSource: LocationDataSourceProtocol {
                 node.code = LocationNode.combineNodeCodes([listNode.code, node.code])
             }
 
-            return listNode
+            // Indicates if the relays are filtered by ``Ownership`` or ``Provider``, node should be added while it has children
+            if isFiltered {
+                guard !listNode.children.isEmpty else {
+                    continue
+                }
+                nodes.append(listNode)
+            } else {
+                nodes.append(listNode)
+            }
         }
     }
 

ios/MullvadVPN/View controllers/SelectLocation/LocationDataSource.swift

@@ -17,6 +17,7 @@ final class LocationDataSource: UITableViewDiffableDataSource<LocationSection, L
     private let tableView: UITableView
     private var dataSources: [LocationDataSourceProtocol] = []
     private var selectedItem: LocationCellViewModel?
+    private var hasFilter = false
 
     var didSelectRelayLocations: ((UserSelectedRelays) -> Void)?
     var didTapEditCustomLists: (() -> Void)?
@@ -47,6 +48,8 @@ final class LocationDataSource: UITableViewDiffableDataSource<LocationSection, L
     }
 
     func setRelays(_ response: REST.ServerRelaysResponse, selectedRelays: UserSelectedRelays?, filter: RelayFilter) {
+        hasFilter = filter.providers != .any || filter.ownership != .any
+
         let allLocationsDataSource =
             dataSources.first(where: { $0 is AllLocationDataSource }) as? AllLocationDataSource
 
@@ -58,7 +61,7 @@ final class LocationDataSource: UITableViewDiffableDataSource<LocationSection, L
         }
 
         allLocationsDataSource?.reload(response, relays: relays)
-        customListsDataSource?.reload(allLocationNodes: allLocationsDataSource?.nodes ?? [])
+        customListsDataSource?.reload(allLocationNodes: allLocationsDataSource?.nodes ?? [], isFiltered: hasFilter)
 
         mapSelectedItem(from: selectedRelays)
         filterRelays(by: currentSearchString)
@@ -101,7 +104,7 @@ final class LocationDataSource: UITableViewDiffableDataSource<LocationSection, L
         let customListsDataSource =
             dataSources.first(where: { $0 is CustomListsDataSource }) as? CustomListsDataSource
 
-        customListsDataSource?.reload(allLocationNodes: allLocationsDataSource?.nodes ?? [])
+        customListsDataSource?.reload(allLocationNodes: allLocationsDataSource?.nodes ?? [], isFiltered: hasFilter)
 
         mapSelectedItem(from: selectedRelays)
         filterRelays(by: currentSearchString, scrollToSelected: false)

ios/MullvadVPNTests/Location/CustomListsDataSourceTests.swift

@@ -63,7 +63,7 @@ class CustomListsDataSourceTests: XCTestCase {
 extension CustomListsDataSourceTests {
     private func setUpDataSource() {
         dataSource = CustomListsDataSource(repository: CustomListsRepositoryStub(customLists: customLists))
-        dataSource.reload(allLocationNodes: allLocationNodes)
+        dataSource.reload(allLocationNodes: allLocationNodes, isFiltered: false)
     }
 
     private func createAllLocationNodes() {