Filter by destination port before asserting

buggmagnet · buggmagnet · commit b3acb6d22a8c · 2025-02-24T09:58:25.000+01:00
diff --git a/ios/MullvadVPNUITests/RelayTests.swift b/ios/MullvadVPNUITests/RelayTests.swift
@@ -194,12 +194,12 @@ class RelayTests: LoggedInWithTimeUITestCase {
             .tapDisconnectButton()
         let capturedStreams = stopPacketCapture()
 
+        // The capture will contain several streams where `other_addr` contains the IP the device connected to
+        // One stream will be for the source port, the other for the destination port
         let streamFromPeeerToRelay = try XCTUnwrap(
-            capturedStreams
-                .filter { $0.destinationAddress == connectedToIPAddress }.first
+            capturedStreams.filter { $0.destinationAddress == connectedToIPAddress && $0.destinationPort == 80 }.first
         )
 
-        XCTAssertTrue(streamFromPeeerToRelay.destinationPort == 80)
         XCTAssertTrue(streamFromPeeerToRelay.transportProtocol == .TCP)
     }
 

Original file line number	Diff line number	Diff line change
`@@ -194,12 +194,12 @@ class RelayTests: LoggedInWithTimeUITestCase {`
`194`	`194`	`.tapDisconnectButton()`
`195`	`195`	`let capturedStreams = stopPacketCapture()`
`196`	`196`
	`197`	+ // The capture will contain several streams where `other_addr` contains the IP the device connected to
	`198`	`+ // One stream will be for the source port, the other for the destination port`
`197`	`199`	`let streamFromPeeerToRelay = try XCTUnwrap(`
`198`		`- capturedStreams`
`199`		`- .filter { $0.destinationAddress == connectedToIPAddress }.first`
	`200`	`+ capturedStreams.filter { $0.destinationAddress == connectedToIPAddress && $0.destinationPort == 80 }.first`
`200`	`201`	`)`
`201`	`202`
`202`		`- XCTAssertTrue(streamFromPeeerToRelay.destinationPort == 80)`
`203`	`203`	`XCTAssertTrue(streamFromPeeerToRelay.transportProtocol == .TCP)`
`204`	`204`	`}`
`205`	`205`