Fix not showing the correct api access method in use on app reinstall

Jon Petersson · Jon Petersson · commit ba00af75f528 · 2024-03-21T15:13:42.000+01:00
diff --git a/ios/MullvadREST/Transport/AccessMethodIterator.swift b/ios/MullvadREST/Transport/AccessMethodIterator.swift
@@ -37,14 +37,12 @@ class AccessMethodIterator {
     }
 
     private func refreshCacheIfNeeded() {
-        /// Validating the index of `lastReachableApiAccessCache` after any changes in `AccessMethodRepository`
+        // Validating the index of `lastReachableApiAccessCache` after any changes in `AccessMethodRepository`
         if let firstIndex = enabledConfigurations.firstIndex(where: { $0.id == self.lastReachableApiAccessId }) {
             index = firstIndex
-        } else {
-            /// When `firstIndex` is `nil`, that means the current configuration is not valid anymore
-            /// Invalidating cache by replacing the `current` to the next enabled access method
-            dataSource.saveLastReachable(pick())
         }
+
+        dataSource.saveLastReachable(pick())
     }
 
     func rotate() {

Original file line number	Diff line number	Diff line change
`@@ -37,14 +37,12 @@ class AccessMethodIterator {`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`private func refreshCacheIfNeeded() {`
`40`		- /// Validating the index of `lastReachableApiAccessCache` after any changes in `AccessMethodRepository`
	`40`	+ // Validating the index of `lastReachableApiAccessCache` after any changes in `AccessMethodRepository`
`41`	`41`	`if let firstIndex = enabledConfigurations.firstIndex(where: { $0.id == self.lastReachableApiAccessId }) {`
`42`	`42`	`index = firstIndex`
`43`		`- } else {`
`44`		- /// When `firstIndex` is `nil`, that means the current configuration is not valid anymore
`45`		- /// Invalidating cache by replacing the `current` to the next enabled access method
`46`		`- dataSource.saveLastReachable(pick())`
`47`	`43`	`}`
	`44`	`+`
	`45`	`+ dataSource.saveLastReachable(pick())`
`48`	`46`	`}`
`49`	`47`
`50`	`48`	`func rotate() {`