Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add guide for auto connect and lockdown mode #5643

Merged
merged 10 commits into from
Feb 19, 2024

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Jan 3, 2024

This is a continuation of: #5592


This change is Reviewable

Copy link

linear bot commented Jan 3, 2024

@albin-mullvad albin-mullvad added the Android Issues related to Android label Jan 3, 2024
@Pururun Pururun force-pushed the add-guide-for-auto-connect-and-lockdown-mode-droid-548 branch from 37a0c74 to 0f77d86 Compare January 3, 2024 11:54
Copy link
Contributor

@sabercodic sabercodic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 18 of 18 files at r1, 5 of 5 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun added the On hold Means the PR is paused for some reason. No need to review it for now label Jan 4, 2024
@Pururun
Copy link
Contributor Author

Pururun commented Jan 4, 2024

This is on hold waiting for design review.

@Pururun Pururun force-pushed the add-guide-for-auto-connect-and-lockdown-mode-droid-548 branch 4 times, most recently from bbfbd85 to 0cf8d92 Compare January 15, 2024 13:05
@Pururun
Copy link
Contributor Author

Pururun commented Jan 15, 2024

This is now on hold waiting for input from @Rawa

@Pururun Pururun force-pushed the add-guide-for-auto-connect-and-lockdown-mode-droid-548 branch 2 times, most recently from f23a9c0 to a70136b Compare February 8, 2024 09:35
@Pururun
Copy link
Contributor Author

Pururun commented Feb 8, 2024

This has been approved by design and @Rawa so it is now open for review again.

@Pururun Pururun requested a review from Rawa February 8, 2024 09:38
@Pururun Pururun removed the On hold Means the PR is paused for some reason. No need to review it for now label Feb 8, 2024
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r4, 1 of 2 files at r5, 4 of 4 files at r6, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Pururun)


android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/AutoConnectCarousel.kt line 72 at r6 (raw file):

@OptIn(ExperimentalFoundationApi::class)
@Composable
fun AutoConnectCarousel() {

This function is a bit long, possibly worth considering breaking it apart to:

  • PageContent (Insides of the horizontal pager)
  • PageIndicator (Last Row in this function

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/VpnSettingsScreen.kt line 297 at r6 (raw file):

        snackbarHostState = snackbarHostState
    ) { modifier, lazyListState ->
        val context = LocalContext.current

I think we should avoid using LocalContext.current as much as possible, also if VPN settings are available is something that should be described into the view state. Maybe creating a UseCase that injects the applicationContext to find this information out is a better alternative?

@Pururun Pururun force-pushed the add-guide-for-auto-connect-and-lockdown-mode-droid-548 branch from a70136b to 3782f76 Compare February 8, 2024 13:59
Copy link
Contributor Author

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 20 of 29 files reviewed, 2 unresolved discussions (waiting on @Rawa and @sabercodic)


android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/VpnSettingsScreen.kt line 297 at r6 (raw file):

Previously, Rawa (David Göransson) wrote…

I think we should avoid using LocalContext.current as much as possible, also if VPN settings are available is something that should be described into the view state. Maybe creating a UseCase that injects the applicationContext to find this information out is a better alternative?

Added UseCase


android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/AutoConnectCarousel.kt line 72 at r6 (raw file):

Previously, Rawa (David Göransson) wrote…

This function is a bit long, possibly worth considering breaking it apart to:

  • PageContent (Insides of the horizontal pager)
  • PageIndicator (Last Row in this function

I made the screen more to how we made our other screens.

@Pururun Pururun requested a review from Rawa February 8, 2024 15:36
@Pururun Pururun force-pushed the add-guide-for-auto-connect-and-lockdown-mode-droid-548 branch from 9f5768e to b4bf0d5 Compare February 8, 2024 16:07
@Rawa Rawa requested review from sabercodic and removed request for sabercodic and Rawa February 9, 2024 09:08
@Pururun Pururun force-pushed the add-guide-for-auto-connect-and-lockdown-mode-droid-548 branch 2 times, most recently from 1e57725 to d0ad011 Compare February 9, 2024 12:49
@Pururun Pururun requested a review from Rawa February 9, 2024 12:53
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 11 of 11 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)


android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/VpnSettingsScreen.kt line 297 at r6 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Added UseCase

Nice! 👏


android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/AutoConnectCarousel.kt line 72 at r6 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

I made the screen more to how we made our other screens.

:lgtm: Good job! 🥇

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the add-guide-for-auto-connect-and-lockdown-mode-droid-548 branch 3 times, most recently from 5d1d603 to 87412f0 Compare February 15, 2024 22:33
@Pururun Pururun requested a review from Rawa February 16, 2024 12:40
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r8, 3 of 3 files at r9, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 3 files at r9.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the add-guide-for-auto-connect-and-lockdown-mode-droid-548 branch 2 times, most recently from c22ced9 to 1ea842f Compare February 19, 2024 08:15
MaryamShaghaghi and others added 10 commits February 19, 2024 11:19
Co-Authored-By: Boban Sijuk <49131853+Boki91@users.noreply.github.com>
Co-Authored-By: Boban Sijuk <49131853+Boki91@users.noreply.github.com>
Co-Authored-By: Boban Sijuk <49131853+Boki91@users.noreply.github.com>
Co-Authored-By: Boban Sijuk <49131853+Boki91@users.noreply.github.com>
Co-Authored-By: Boban Sijuk <49131853+Boki91@users.noreply.github.com>
@Pururun Pururun force-pushed the add-guide-for-auto-connect-and-lockdown-mode-droid-548 branch from 1ea842f to f8f7da0 Compare February 19, 2024 10:19
@Pururun Pururun merged commit 8ae2314 into main Feb 19, 2024
17 of 18 checks passed
@Pururun Pururun deleted the add-guide-for-auto-connect-and-lockdown-mode-droid-548 branch February 19, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants