-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add guide for auto connect and lockdown mode #5643
Add guide for auto connect and lockdown mode #5643
Conversation
37a0c74
to
0f77d86
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 18 of 18 files at r1, 5 of 5 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
This is on hold waiting for design review. |
bbfbd85
to
0cf8d92
Compare
This is now on hold waiting for input from @Rawa |
f23a9c0
to
a70136b
Compare
This has been approved by design and @Rawa so it is now open for review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r4, 1 of 2 files at r5, 4 of 4 files at r6, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @Pururun)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/AutoConnectCarousel.kt
line 72 at r6 (raw file):
@OptIn(ExperimentalFoundationApi::class) @Composable fun AutoConnectCarousel() {
This function is a bit long, possibly worth considering breaking it apart to:
- PageContent (Insides of the horizontal pager)
- PageIndicator (Last Row in this function
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/VpnSettingsScreen.kt
line 297 at r6 (raw file):
snackbarHostState = snackbarHostState ) { modifier, lazyListState -> val context = LocalContext.current
I think we should avoid using LocalContext.current
as much as possible, also if VPN settings are available is something that should be described into the view state. Maybe creating a UseCase that injects the applicationContext
to find this information out is a better alternative?
a70136b
to
3782f76
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 20 of 29 files reviewed, 2 unresolved discussions (waiting on @Rawa and @sabercodic)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/VpnSettingsScreen.kt
line 297 at r6 (raw file):
Previously, Rawa (David Göransson) wrote…
I think we should avoid using
LocalContext.current
as much as possible, also if VPN settings are available is something that should be described into the view state. Maybe creating a UseCase that injects theapplicationContext
to find this information out is a better alternative?
Added UseCase
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/AutoConnectCarousel.kt
line 72 at r6 (raw file):
Previously, Rawa (David Göransson) wrote…
This function is a bit long, possibly worth considering breaking it apart to:
- PageContent (Insides of the horizontal pager)
- PageIndicator (Last Row in this function
I made the screen more to how we made our other screens.
9f5768e
to
b4bf0d5
Compare
1e57725
to
d0ad011
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 11 of 11 files at r7, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/screen/VpnSettingsScreen.kt
line 297 at r6 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
Added UseCase
Nice! 👏
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/component/AutoConnectCarousel.kt
line 72 at r6 (raw file):
Previously, Pururun (Jonatan Rhodin) wrote…
I made the screen more to how we made our other screens.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved
5d1d603
to
87412f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r8, 3 of 3 files at r9, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r9.
Reviewable status:complete! all files reviewed, all discussions resolved
c22ced9
to
1ea842f
Compare
Co-Authored-By: Boban Sijuk <49131853+Boki91@users.noreply.github.com>
Co-Authored-By: Boban Sijuk <49131853+Boki91@users.noreply.github.com>
Co-Authored-By: Boban Sijuk <49131853+Boki91@users.noreply.github.com>
Co-Authored-By: Boban Sijuk <49131853+Boki91@users.noreply.github.com>
Co-Authored-By: Boban Sijuk <49131853+Boki91@users.noreply.github.com>
1ea842f
to
f8f7da0
Compare
This is a continuation of: #5592
This change is