Remove manual cargo:rerun-if-changed when building protos #5750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faern
approved these changes
Feb 2, 2024
pronebird
force-pushed
the
tonic-rerun
branch
from
ade38d4 to
423f983
Compare
|
@faern sure, patched all invocations of |
|
Can't say why nightly is failing. Perhaps needs a re-run. |
|
Merged! Thank you for the simplification :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that
tonic_build::compile_protos()already injects "cargo:rerun-if-changed" statements for cargo: https://github.com/hyperium/tonic/blob/v0.10.0/tonic-build/src/prost.rs#L40If you run
cargo build -vvyou'll see the following statements already added bytonic_build:Hence no need to do that manually.
This change is