Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify test class suffix #5803

Merged
merged 3 commits into from
Feb 12, 2024
Merged

Conversation

albin-mullvad
Copy link
Collaborator

@albin-mullvad albin-mullvad commented Feb 12, 2024

This PR aims to unify the test class suffix (*Test) used in the project by:

  • Adding a konsist check to check the test class suffix.
  • Making sure the code is compliant with the new konsist check.

This change is Reviewable

@albin-mullvad albin-mullvad added the Android Issues related to Android label Feb 12, 2024
@albin-mullvad albin-mullvad requested a review from Rawa February 12, 2024 08:05
@albin-mullvad albin-mullvad self-assigned this Feb 12, 2024
Copy link

linear bot commented Feb 12, 2024

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition 👍 :lgtm:

Reviewed 9 of 10 files at r1, all commit messages.
Reviewable status: 9 of 10 files reviewed, all discussions resolved

Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 10 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad merged commit e48c0ab into main Feb 12, 2024
@albin-mullvad albin-mullvad deleted the unify-test-class-suffix-droid-678 branch February 12, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants