Fix pointless API method rotations when concurrent requests fail #5823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlon
force-pushed
the
fix-concurrent-access-rotations
branch
from
b3ece8f to
efe2d26
Compare
dlon
force-pushed
the
fix-concurrent-access-rotations
branch
from
efe2d26 to
d2865ae
Compare
MarkusPettersson98
approved these changes
Feb 16, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
dlon
force-pushed
the
refactor-access-mode-tx
branch
from
bd6fe5c to
e471d07
Compare
dlon
force-pushed
the
fix-concurrent-access-rotations
branch
from
d2865ae to
6f19fea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new method shouldn't be rotated until it has been used. This was particularly annoying with the default settings when an even number of requests failed, as the current (broken) method would keep being used.
Fix DES-636.
This change is