Optimize map contour lines and fix long line bug #5852
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the changes needed to match with mullvad/globe-mesh-builder#1. The description for this change is basically the same, so I'll copy it over:
This PR does three things to the contour lines between geographical entities:
HashSet
with seen edges and skip already drawn edgesGL_LINE_STRIP
instead of the currentGL_LINES
. This reduces the size of theland_contour_indices.bin
file from873 kb
bytes to392 kb
.If we had access to OpenGL 3.1 we could draw the line strips much nicer with a single draw call thanks to
glPrimitiveRestartIndex
. But sadly this is not available to us. Instead this uses a hack where we continue the continuous line by drawing underneath the earths crust to the new position and pop back up there.This change is