Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compose tests not drawing edge-to-edge #5854

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

albin-mullvad
Copy link
Collaborator

@albin-mullvad albin-mullvad commented Feb 23, 2024

This PR aims to make sure all compose tests use edge-to-edge drawing in order to replicate how the MainActivity works.


This change is Reviewable

@albin-mullvad albin-mullvad added the Android Issues related to Android label Feb 23, 2024
Copy link

linear bot commented Feb 23, 2024

@albin-mullvad albin-mullvad self-assigned this Feb 23, 2024
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 17 of 17 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad force-pushed the compose-tests-not-drawing-edge-to-edge-droid-701 branch from 731a9bf to 8c28fbf Compare February 26, 2024 09:27
@albin-mullvad albin-mullvad merged commit 3543421 into main Feb 26, 2024
12 checks passed
@albin-mullvad albin-mullvad deleted the compose-tests-not-drawing-edge-to-edge-droid-701 branch February 26, 2024 09:36
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🤩 :lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants