Updated workflow to be compatible with xcconfig changes in main

[niklasberglund]

Adapted to changes that have been merged to main which affect the workflow:

• MULLVAD_IOS_DEVICE_PIN_CODE has been renamed to IOS_DEVICE_PIN_CODE
• In UITests.xcconfig.template HAS_TIME_ACCOUNT_NUMBER and NO_TIME_ACCOUNT_NUMBER are specified per configuration.

---

This change is 

[rablador]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[buggmagnet]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @niklasberglund)

---

.github/workflows/ios-end-to-end-tests.yml line 46 at r1 (raw file):

            "/TEST_DEVICE_IDENTIFIER_UUID =/ s/= .*/= $TEST_DEVICE_IDENTIFIER_UUID/" \
            UITests.xcconfig
          printf "\n" >> UITests.xcconfig

Is there any reason we use printf instead of echo here ? We don't need to format any arguments, so I don't see why those wouldn't be echo calls instead

[niklasberglund]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @buggmagnet and @rablador)

---

.github/workflows/ios-end-to-end-tests.yml line 46 at r1 (raw file):

Previously, buggmagnet wrote…

Is there any reason we use printf instead of echo here ? We don't need to format any arguments, so I don't see why those wouldn't be echo calls instead

Its common practice for shell scripts to use printf instead of echo because of portability issues with echo. In this case we don't need high portability anyways and it's not advanced usage that is likely to differ between different platforms which we're not going to be running this on either way. Have changed to using echo.

[buggmagnet]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved