Apply filtering on custom lists

[mojganii]

When a filter is applied, the custom lists should only display items that match the specified constraints. Any items that do not meet these constraints should be excluded from the list.

---

This change is 

[linear]

IOS-564 Apply relay filters to Custom lists

[rablador]

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @mojganii)

---

ios/MullvadVPN/View controllers/SelectLocation/CustomListsDataSource.swift line 28 at r1 (raw file):

    /// Constructs a collection of node trees by copying each matching counterpart
    /// from the complete list of nodes created in ``AllLocationDataSource``.
    func reload(allLocationNodes: [LocationNode], isFiltered: Bool) {

Nit: This change can be made much smaller by changing the original code from ...fetchAll().map to ...fetchAll().compactMap and ... (see below)

---

ios/MullvadVPN/View controllers/SelectLocation/CustomListsDataSource.swift line 51 at r1 (raw file):

            }

            // Indicates if the relays are filtered by ``Ownership`` or ``Provider``, node should be added while it has children

... and:

if isFiltered && listNode.children.isEmpty {
    return nil
} else {
     return listNode
}

[rablador]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)

---

ios/MullvadVPN/View controllers/SelectLocation/CustomListsDataSource.swift line 28 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

Nit: This change can be made much smaller by changing the original code from ...fetchAll().map to ...fetchAll().compactMap and ... (see below)

Nit: This change can be made much smaller by changing the original code to use a compactMap instead.

Code snippet:

      nodes = repository.fetchAll().compactMap { list in
            
            [...]

            // Indicates if the relays are filtered by ``Ownership`` or ``Provider``, node should be added while it has children
            if isFiltered && listNode.children.isEmpty {
                return nil
            } else {
                return listNode
            }
        }

[rablador]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)

---

ios/MullvadVPN/View controllers/SelectLocation/CustomListsDataSource.swift line 28 at r1 (raw file):

    /// Constructs a collection of node trees by copying each matching counterpart
    /// from the complete list of nodes created in ``AllLocationDataSource``.
    func reload(allLocationNodes: [LocationNode], isFiltered: Bool) {

Nit: This change can be made much smaller by changing the original code to use a compactMap instead.

Code snippet:

nodes = repository.fetchAll().compactMap { list in
    [...]
    
    // Indicates if the relays are filtered by ``Ownership`` or ``Provider``, node should be added while it has children
    if isFiltered && listNode.children.isEmpty {
        return nil
    } else {
        return listNode
    }
}

[rablador]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)

[mojganii]

Reviewable status: 1 of 3 files reviewed, 1 unresolved discussion (waiting on @rablador)

---

ios/MullvadVPN/View controllers/SelectLocation/CustomListsDataSource.swift line 28 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

Nit: This change can be made much smaller by changing the original code to use a compactMap instead.

Considered

---

ios/MullvadVPN/View controllers/SelectLocation/CustomListsDataSource.swift line 51 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

... and:

if isFiltered && listNode.children.isEmpty {
    return nil
} else {
     return listNode
}

Indeed.

[rablador]

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[rablador]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[buggmagnet]

Reviewed 1 of 3 files at r1, 1 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved