Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the title 'Server IP Override' up #5983

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

rablador
Copy link
Contributor

@rablador rablador commented Mar 20, 2024

In the Server IP Override section, the title should be at the same level as other top level titles in pages such as API Access or VPN Settings.


This change is Reviewable

@rablador rablador added the iOS Issues related to iOS label Mar 20, 2024
@rablador rablador requested review from mojganii and acb-mv March 20, 2024 07:57
Copy link

linear bot commented Mar 20, 2024

Copy link
Contributor Author

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 10 files reviewed, 2 unresolved discussions


ios/MullvadVPN/Coordinators/Settings/APIAccess/List/ListAccessMethodCoordinator.swift line 76 at r1 (raw file):

    }

    private func about() {

Unrelated changes, but decided to fix anyway.


ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsDataSource.swift line 380 at r1 (raw file):

        let sectionIdentifier = snapshot().sectionIdentifiers[section]

        return switch sectionIdentifier {

Unrelated, but decided to fix anyway.

Copy link
Contributor

@acb-mv acb-mv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 10 files at r1, all commit messages.
Reviewable status: 5 of 10 files reviewed, 3 unresolved discussions (waiting on @rablador)


ios/MullvadVPN/Coordinators/Settings/IPOverride/IPOverrideViewController.swift line 58 at r1 (raw file):

        view.directionalLayoutMargins = UIMetrics.contentHeadingLayoutMargins

        confgiureNavigation()

Misspelling of "configure"

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @rablador)


ios/MullvadVPN/Coordinators/Settings/IPOverride/IPOverrideHeaderView.swift line 11 at r1 (raw file):

import UIKit

/// Header view pinned at the top of ``AccessMethodListViewController``.

This comment and the next one refers to a different feature


ios/MullvadVPN/Coordinators/Settings/IPOverride/IPOverrideHeaderView.swift line 55 at r1 (raw file):

        let body = NSLocalizedString(
            "ACCESS_METHOD_HEADER_BODY",
            tableName: "APIAccess",

This is the wrong table name, same below


ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsDataSource.swift line 380 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

Unrelated, but decided to fix anyway.

nice


ios/MullvadVPN.xcodeproj/project.pbxproj line 1740 at r1 (raw file):

		7A21DACE2A30AA3700A787A9 /* UITextField+Appearance.swift */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.swift; path = "UITextField+Appearance.swift"; sourceTree = "<group>"; };
		7A2882692BA8336600FD9F20 /* VPNSettingsCoordinator.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = VPNSettingsCoordinator.swift; sourceTree = "<group>"; };
		7A28826C2BAAC9DE00FD9F20 /* IPOverrideHeaderView.swift */ = {isa = PBXFileReference; lastKnownFileType = sourcecode.swift; path = IPOverrideHeaderView.swift; sourceTree = "<group>"; };

"Sort by name"

@rablador rablador force-pushed the move-up-the-title-of-server-ip-override-ios-558 branch from bac1805 to 8b50154 Compare April 4, 2024 08:40
Copy link
Contributor Author

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 6 of 12 files reviewed, 5 unresolved discussions (waiting on @acb-mv and @buggmagnet)


ios/MullvadVPN/Coordinators/Settings/IPOverride/IPOverrideHeaderView.swift line 11 at r1 (raw file):

Previously, buggmagnet wrote…

This comment and the next one refers to a different feature

Done.


ios/MullvadVPN/Coordinators/Settings/IPOverride/IPOverrideHeaderView.swift line 55 at r1 (raw file):

Previously, buggmagnet wrote…

This is the wrong table name, same below

Done.


ios/MullvadVPN/Coordinators/Settings/IPOverride/IPOverrideViewController.swift line 58 at r1 (raw file):

Previously, acb-mv wrote…

Misspelling of "configure"

Done.


ios/MullvadVPN.xcodeproj/project.pbxproj line 1740 at r1 (raw file):

Previously, buggmagnet wrote…

"Sort by name"

Done.

@rablador rablador force-pushed the move-up-the-title-of-server-ip-override-ios-558 branch 2 times, most recently from e2579bf to 33a575a Compare April 4, 2024 09:00
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

:lgtm:

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @acb-mv)

@buggmagnet buggmagnet force-pushed the move-up-the-title-of-server-ip-override-ios-558 branch from 33a575a to 7c1f112 Compare April 5, 2024 08:02
@rablador rablador removed the request for review from mojganii April 8, 2024 08:15
Copy link
Collaborator

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 9 of 11 files reviewed, 1 unresolved discussion (waiting on @buggmagnet)

@buggmagnet buggmagnet force-pushed the move-up-the-title-of-server-ip-override-ios-558 branch from 7c1f112 to 127b336 Compare April 11, 2024 11:28
Copy link
Contributor

@acb-mv acb-mv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion

@buggmagnet buggmagnet merged commit c2cf8b5 into main Apr 11, 2024
6 of 7 checks passed
@buggmagnet buggmagnet deleted the move-up-the-title-of-server-ip-override-ios-558 branch April 11, 2024 11:39
Copy link

🚨 End to end tests failed. Please check the failed workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants