Fix selection of custom list location not being retained #5995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rablador
force-pushed
the
fix-selection-of-custom-list-location-not-being-retained-ios-569
branch
from
2131b2c to
1c4d726
Compare
buggmagnet
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
nice find !
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
buggmagnet
force-pushed
the
fix-selection-of-custom-list-location-not-being-retained-ios-569
branch
from
1c4d726 to
d55340c
Compare
buggmagnet
deleted the
fix-selection-of-custom-list-location-not-being-retained-ios-569
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selecting a location in a custom list in location view is not retained when closing and opening the view again. This is due to a bug in how the node tree is created with incorrect parent nodes.
This change is