Fix not showing the correct api access method in use on app reinstall #6004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buggmagnet
approved these changes
Mar 21, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)
ios/MullvadREST/Transport/AccessMethodIterator.swift line 41 at r1 (raw file):
private func refreshCacheIfNeeded() { // Validating the index of `lastReachableApiAccessCache` after any changes in `AccessMethodRepository` if let firstIndex = enabledConfigurations.firstIndex(where: { $0.id == self.lastReachableApiAccessId }) {
nit
we can remove self here
rablador
force-pushed
the
api-access-method-does-not-show-show-the-correct-method-ios-563
branch
from
ba00af7 to
8addddb
Compare
rablador
commented
Mar 21, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @buggmagnet)
ios/MullvadREST/Transport/AccessMethodIterator.swift line 41 at r1 (raw file):
Previously, buggmagnet wrote…
nit
we can removeselfhere
Done
buggmagnet
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
buggmagnet
force-pushed
the
api-access-method-does-not-show-show-the-correct-method-ios-563
branch
from
8addddb to
bfb83c2
Compare
buggmagnet
deleted the
api-access-method-does-not-show-show-the-correct-method-ios-563
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "Direct" is disabled and "Mullvad bridges" is in use, if app is then removed and reinstalled, "Direct" is enabled again (correct) and "Mullvad bridges" in use (wrong, should be "Direct").
This change is