Skip to content

Add test that makes sure connecting works without the API #6013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

MarkusPettersson98
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 commented Mar 22, 2024

This PR adds a test to verify that the app can connect to a VPN server and get working internet even if the API is unavailable. As long as the user has managed to log in to the app, the rest should just work.


This change is Reviewable

@MarkusPettersson98 MarkusPettersson98 requested a review from dlon March 22, 2024 14:21
Copy link

linear bot commented Mar 22, 2024

Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @MarkusPettersson98)


test/test-manager/src/tests/helpers.rs line 25 at r1 (raw file):

use test_rpc::{package::Package, AmIMullvad, ServiceClient};

/// TODO: Document

TODO


test/test-manager/src/tests/helpers.rs line 342 at r1 (raw file):

/// # Note
/// This is just a thin wrapper around [`ServiceClient::set_daemon_environment`] which also
/// invalides the old [`MullvadProxyClient`].

Nit: invalidates

@MarkusPettersson98 MarkusPettersson98 force-pushed the write-test-that-makes-sure-connecting-works-without-the-api-des-586 branch from 0932f2c to 5d7906b Compare March 22, 2024 15:44
Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Get rid of transitive dependency on `is-terminal` and `termcolor`
@MarkusPettersson98 MarkusPettersson98 force-pushed the write-test-that-makes-sure-connecting-works-without-the-api-des-586 branch from 5d7906b to 1bb03d8 Compare March 25, 2024 10:07
@MarkusPettersson98 MarkusPettersson98 merged commit 76f6ed5 into main Mar 25, 2024
@MarkusPettersson98 MarkusPettersson98 deleted the write-test-that-makes-sure-connecting-works-without-the-api-des-586 branch March 25, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants