Exit without dropping the tokio runtime #6035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlon
changed the title
dlon
force-pushed
the
fix-drop-tokio-runtime
branch
from
4f34e22 to
9004829
Compare
hulthe
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1.
Reviewable status: 0 of 1 files reviewed, all discussions resolved
dlon
force-pushed
the
fix-drop-tokio-runtime
branch
from
12fc354 to
ed7bf4c
Compare
dlon
force-pushed
the
fix-drop-tokio-runtime
branch
from
ed7bf4c to
a861751
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like the default behavior by the runtime when dropped is to block for a long time while there are still incomplete tasks.
Close DES-719.
This change is