Test custom DNS #6041
Merged
Test custom DNS #6041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niklasberglund
force-pushed
the
test-custom-dns-ios-437
branch
2 times, most recently
from
414a921 to
abd9899
Compare
pinkisemils
approved these changes
Apr 5, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @buggmagnet and @pinkisemils)
buggmagnet
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @niklasberglund)
ios/MullvadVPNUITests/RelayTests.swift line 194 at r1 (raw file):
.tapDoneButton() try Networking.verifyDNSServerProvider(dnsServerProviderName, isMullvad: false)
nit
I just wanted to say, I absolutely love how easy to read this is.
buggmagnet
force-pushed
the
test-custom-dns-ios-437
branch
from
abd9899 to
daa31da
Compare
acb-mv
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @buggmagnet, @niklasberglund, and @pinkisemils)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented test for custom DNS server. The test specifies a custom DNS server and verifies that it is actually used. To test this PR run the test
testCustomDNSunderRelayTests.This change is