-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add time left properly displayed test #6049
Add time left properly displayed test #6049
Conversation
fb4fdd1
to
c26aa2f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @niklasberglund)
ios/MullvadVPNUITests/Pages/AccountPage.swift
line 57 at r1 (raw file):
let paidUntilLabelText = app.staticTexts[AccessibilityIdentifier.accountPagePaidUntilLabel].label let dateFormatter = DateFormatter() dateFormatter.dateFormat = "d MMM yyyy 'at' H:mm"
We should not use custom date formats if we can avoid it, this should probably be iso8601
ios/MullvadVPNUITests/Pages/AccountPage.swift
line 64 at r1 (raw file):
} print(paidUntilLabelDate)
Let 's remove this
02e42c7
to
7b1efd3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 3 of 5 files reviewed, 2 unresolved discussions (waiting on @acb-mv, @buggmagnet, and @pinkisemils)
ios/MullvadVPNUITests/Pages/AccountPage.swift
line 57 at r1 (raw file):
Previously, buggmagnet wrote…
We should not use custom date formats if we can avoid it, this should probably be
iso8601
It's some custom date format that DateFormatter
produces. Can avoid the custom dateFormat
by setting
dateFormatter.dateStyle = .medium
dateFormatter.timeStyle = .short
ios/MullvadVPNUITests/Pages/AccountPage.swift
line 64 at r1 (raw file):
Previously, buggmagnet wrote…
Let 's remove this
Removed 👍
7b1efd3
to
4a89dda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
🚨 End to end tests failed. Please check the failed workflow run. |
Implemented test verifying that time left is properly displayed. To test the changes in this PR run the test
testTimeLeft
underAccountTests
.This change is