Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time left properly displayed test #6049

Conversation

niklasberglund
Copy link
Contributor

@niklasberglund niklasberglund commented Apr 2, 2024

Implemented test verifying that time left is properly displayed. To test the changes in this PR run the test testTimeLeft under AccountTests.


This change is Reviewable

@niklasberglund niklasberglund added the iOS Issues related to iOS label Apr 2, 2024
Copy link

linear bot commented Apr 2, 2024

@niklasberglund niklasberglund force-pushed the test-that-app-properly-displays-time-left-in-account-view-ios-433 branch from fb4fdd1 to c26aa2f Compare April 2, 2024 09:13
Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@acb-mv acb-mv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 5 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @niklasberglund)


ios/MullvadVPNUITests/Pages/AccountPage.swift line 57 at r1 (raw file):

        let paidUntilLabelText = app.staticTexts[AccessibilityIdentifier.accountPagePaidUntilLabel].label
        let dateFormatter = DateFormatter()
        dateFormatter.dateFormat = "d MMM yyyy 'at' H:mm"

We should not use custom date formats if we can avoid it, this should probably be iso8601


ios/MullvadVPNUITests/Pages/AccountPage.swift line 64 at r1 (raw file):

        }

        print(paidUntilLabelDate)

Let 's remove this

@niklasberglund niklasberglund force-pushed the test-that-app-properly-displays-time-left-in-account-view-ios-433 branch 2 times, most recently from 02e42c7 to 7b1efd3 Compare April 11, 2024 11:50
Copy link
Contributor Author

@niklasberglund niklasberglund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 3 of 5 files reviewed, 2 unresolved discussions (waiting on @acb-mv, @buggmagnet, and @pinkisemils)


ios/MullvadVPNUITests/Pages/AccountPage.swift line 57 at r1 (raw file):

Previously, buggmagnet wrote…

We should not use custom date formats if we can avoid it, this should probably be iso8601

It's some custom date format that DateFormatter produces. Can avoid the custom dateFormat by setting

        dateFormatter.dateStyle = .medium
        dateFormatter.timeStyle = .short

ios/MullvadVPNUITests/Pages/AccountPage.swift line 64 at r1 (raw file):

Previously, buggmagnet wrote…

Let 's remove this

Removed 👍

@buggmagnet buggmagnet force-pushed the test-that-app-properly-displays-time-left-in-account-view-ios-433 branch from 7b1efd3 to 4a89dda Compare April 12, 2024 08:26
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@buggmagnet buggmagnet merged commit c4f3d51 into main Apr 12, 2024
7 checks passed
@buggmagnet buggmagnet deleted the test-that-app-properly-displays-time-left-in-account-view-ios-433 branch April 12, 2024 08:27
Copy link

🚨 End to end tests failed. Please check the failed workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants