Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Split tunneling disabled description #6060

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Apr 3, 2024


This change is Reviewable

Copy link

linear bot commented Apr 3, 2024

@Rawa Rawa force-pushed the split-tunneling-description-hidden-droid-814 branch from a6481e7 to 1ba8d9b Compare April 3, 2024 09:01
@Rawa Rawa self-assigned this Apr 3, 2024
@Rawa Rawa added the Android Issues related to Android label Apr 3, 2024
@Rawa Rawa force-pushed the split-tunneling-description-hidden-droid-814 branch from 1ba8d9b to 99bd400 Compare April 4, 2024 13:56
@Rawa Rawa requested review from Pururun and albin-mullvad April 4, 2024 13:56
@Rawa Rawa marked this pull request as ready for review April 4, 2024 13:56
@Rawa Rawa force-pushed the split-tunneling-description-hidden-droid-814 branch 2 times, most recently from d09e66d to f033728 Compare April 4, 2024 13:59
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 22 files reviewed, 1 unresolved discussion (waiting on @Rawa)


android/lib/resource/src/main/res/values/strings.xml line 158 at r1 (raw file):

    <string name="select_location_description">While connected, your real location is masked with a private and secure location in the selected region.</string>
    <string name="split_tunneling_description">Lets you select apps that should access the Internet directly without going through the VPN tunnel.</string>
    <string name="split_tunneling_description_warning">Attention: Split tunneling is a privacy risk.</string>

We should make sure this doesn't get translated.

Code quote:

Split tunneling

Copy link
Contributor Author

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 22 files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)


android/lib/resource/src/main/res/values/strings.xml line 158 at r1 (raw file):

Previously, albin-mullvad wrote…

We should make sure this doesn't get translated.

After internal discussion we have decided on try and fix directly on crowdin

@Rawa Rawa force-pushed the split-tunneling-description-hidden-droid-814 branch 3 times, most recently from e3684ff to 5675484 Compare April 9, 2024 08:19
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 21 of 22 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

@Rawa Rawa force-pushed the split-tunneling-description-hidden-droid-814 branch from 5675484 to da31994 Compare April 9, 2024 08:21
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 21 of 22 files at r1, 1 of 2 files at r2, 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the split-tunneling-description-hidden-droid-814 branch from da31994 to 06abfdf Compare April 9, 2024 09:22
@Rawa Rawa merged commit 88bba34 into main Apr 9, 2024
27 checks passed
@Rawa Rawa deleted the split-tunneling-description-hidden-droid-814 branch April 9, 2024 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants