-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Split tunneling disabled description #6060
Conversation
a6481e7
to
1ba8d9b
Compare
1ba8d9b
to
99bd400
Compare
d09e66d
to
f033728
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 22 files reviewed, 1 unresolved discussion (waiting on @Rawa)
android/lib/resource/src/main/res/values/strings.xml
line 158 at r1 (raw file):
<string name="select_location_description">While connected, your real location is masked with a private and secure location in the selected region.</string> <string name="split_tunneling_description">Lets you select apps that should access the Internet directly without going through the VPN tunnel.</string> <string name="split_tunneling_description_warning">Attention: Split tunneling is a privacy risk.</string>
We should make sure this doesn't get translated.
Code quote:
Split tunneling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 22 files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)
android/lib/resource/src/main/res/values/strings.xml
line 158 at r1 (raw file):
Previously, albin-mullvad wrote…
We should make sure this doesn't get translated.
After internal discussion we have decided on try and fix directly on crowdin
e3684ff
to
5675484
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 21 of 22 files at r1, 2 of 2 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)
5675484
to
da31994
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 21 of 22 files at r1, 1 of 2 files at r2, 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
da31994
to
06abfdf
Compare
This change is