Fix Relayselector not resolving locations under certain constraints #6062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rablador
changed the title
rablador
force-pushed
the
relayselector-cannot-resolve-locations-under-certain-ios-580
branch
from
592105d to
57d3712
Compare
pinkisemils
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
acb-mv
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:
buggmagnet
approved these changes
Apr 8, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
buggmagnet
force-pushed
the
relayselector-cannot-resolve-locations-under-certain-ios-580
branch
from
57d3712 to
f3afd74
Compare
buggmagnet
deleted the
relayselector-cannot-resolve-locations-under-certain-ios-580
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce the issue:
The underlying issue is that relays can be set to not be included in a country when a user sets a country location constraint, i.e. there are relays that should not be considered for selection even though they'd match a location constraint. However, it can be the case that all relays provided by a specific provider are marked to not be included in a country, which is the case for 100TB and US. In this case, the relay selector should disregard the flag and allow the relays anyway. The iOS behavior here should mimic desktop - https://github.com/mullvad/mullvadvpn-app/blob/main/mullvad-relay-selector/src/relay_selector/matcher.rs#L17-L62
This change is