Fix for screenshot tests failing #6092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rablador
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
rablador
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Reviewable status:
mojganii
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Reviewable status:
buggmagnet
approved these changes
Apr 10, 2024
There was a problem hiding this comment.
Reviewable status:
buggmagnet
force-pushed
the
fix-screenshot-tests-failing-ios-594
branch
from
b365dbd to
77f066b
Compare
|
🚨 End to end tests failed. Please check the failed workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshot tests started failing because the button previously always identified by
collapseButtonnow has either accessibility identifiercollapseButtonorexpandButtondepending on it's state.The changes in this PR can be tested by running
testTakeScreenshotsunderMullvadVPNScreenshots.This change is