Skip to content

Fix for screenshot tests failing #6092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 10, 2024
Merged

Fix for screenshot tests failing #6092

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ios/MullvadVPNScreenshots/MullvadVPNScreenshots.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
// Select Sweden, Gothenburg in Select location controller
if case .phone = UIDevice.current.userInterfaceIdiom {
_ = app.buttons[AccessibilityIdentifier.selectLocationButton.rawValue].waitForExistence(timeout: 10)
app.buttons[AccessibilityIdentifier.selectLocationButton.rawValue].tap()

Check failure on line 66 in ios/MullvadVPNScreenshots/MullvadVPNScreenshots.swift

View workflow job for this annotation

GitHub Actions / Screenshot tests 

    testTakeScreenshots, Failed to tap "selectLocationButton" Button: No matches found for Elements matching predicate '"selectLocationButton" IN identifiers' from input {(
}

let countryCell = app.cells["se"]
Expand All @@ -74,8 +74,8 @@
if cityCell.exists {
cityCell.tap()
} else {
_ = countryCell.buttons[AccessibilityIdentifier.collapseButton.rawValue].waitForExistence(timeout: 5)
countryCell.buttons[AccessibilityIdentifier.collapseButton.rawValue].tap()
_ = countryCell.buttons[AccessibilityIdentifier.expandButton.rawValue].waitForExistence(timeout: 5)
countryCell.buttons[AccessibilityIdentifier.expandButton.rawValue].tap()
cityCell.tap()
}

Expand All @@ -87,7 +87,7 @@
// Re-open Select location controller (iPhone only)
if case .phone = UIDevice.current.userInterfaceIdiom {
app.buttons[AccessibilityIdentifier.selectLocationButton.rawValue].tap()
cityCell.buttons[AccessibilityIdentifier.collapseButton.rawValue].tap()
cityCell.buttons[AccessibilityIdentifier.expandButton.rawValue].tap()
snapshot("SelectLocation")

// Tap the "Filter" button and expand each relay filter
Expand Down
Loading