-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change action sheet tint color #6096
Change action sheet tint color #6096
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)
ios/MullvadVPN/Coordinators/LocationCoordinator.swift
line 201 at r1 (raw file):
actionSheet.overrideUserInterfaceStyle = .dark actionSheet.view.tintColor = UIColor(red: 0 / 255.0, green: 150 / 255.0, blue: 255 / 255.0, alpha: 1)
Is there any reason why we don't use 0.0
instead of 255 / 255.0
?
Which in itself is bad because we're dividing an integer with a floating point number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/MullvadVPN/Coordinators/LocationCoordinator.swift
line 201 at r1 (raw file):
Previously, buggmagnet wrote…
Is there any reason why we don't use
0.0
instead of255 / 255.0
?
Which in itself is bad because we're dividing an integer with a floating point number.
I wanted to maintain consistency with other parameter formats. Instead of using '255.0' as a constant, I'll use floating values for them.
2781267
to
1e112e3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
1e112e3
to
810ac5e
Compare
🚨 End to end tests failed. Please check the failed workflow run. |
To enhance the differentiation between enabled and disabled actions, we've opted for a more distinct color that ensures better visibility. This PR implements this change.
This change is