Alphabetical sorting for custom list locations ios 604

[mojganii]

This pull request introduces functionality to display the locations of a custom list in alphabetical sorting within each location group. To achieve this, the following steps were taken:

1. Grouping the locations of a custom list based on Country City, and Host.
2. Implementing alphabetical sorting for each location group.
3. Concatenating them together to create a flat array.
4. Disabling custom lists that have no children, making them unselectable.

before	after

---

This change is 

[linear]

IOS-604 Implement alphabetical sorting for custom list Locations

[rablador]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)

---

ios/MullvadVPN/View controllers/SelectLocation/CustomListLocationNodeBuilder.swift line 56 at r1 (raw file):

private extension CustomListLocationNode {
    func sorted() {

Nit: sorted (in past tense) usually indicates a return value of the sorted array, while simply sort usually indicate sorting in place.

[rablador]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)

[mojganii]

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @rablador)

---

ios/MullvadVPN/View controllers/SelectLocation/CustomListLocationNodeBuilder.swift line 56 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

Nit: sorted (in past tense) usually indicates a return value of the sorted array, while simply sort usually indicate sorting in place.

Done.

[rablador]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[buggmagnet]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[github-actions]

🚨 End to end tests failed. Please check the failed workflow run.