Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missed key into privacy manifest #6116

Conversation

mojganii
Copy link
Collaborator

@mojganii mojganii commented Apr 12, 2024

Apple notified us that we missed NSPrivacyAccessedAPICategoryFileTimestamp in our privacy manifest. This pull request introduces this functionality.


This change is Reviewable

@mojganii mojganii added the iOS Issues related to iOS label Apr 12, 2024
@mojganii mojganii requested review from rablador and buggmagnet April 12, 2024 12:04
@mojganii mojganii self-assigned this Apr 12, 2024
Copy link

linear bot commented Apr 12, 2024

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @mojganii)


ios/MullvadVPN/Supporting Files/PrivacyInfo.xcprivacy line 16 at r1 (raw file):

                <key>NSPrivacyAccessedAPITypeReasons</key>
                <array>
                    <string>C617.1</string>

Please also add reason 3B52.1 because we are also using DocumentPickerViewController now in IP Overrides and we forgot to add it back then.

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)


ios/MullvadVPN/Supporting Files/PrivacyInfo.xcprivacy line 16 at r1 (raw file):

Previously, buggmagnet wrote…

Please also add reason 3B52.1 because we are also using DocumentPickerViewController now in IP Overrides and we forgot to add it back then.

3B52.1 isn't related to DocumentPickerViewController though, right? That one only concerns reading file timestamps and such, which we don't read in ip overrides.

Copy link
Collaborator Author

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)


ios/MullvadVPN/Supporting Files/PrivacyInfo.xcprivacy line 16 at r1 (raw file):

Previously, rablador (Jon Petersson) wrote…

3B52.1 isn't related to DocumentPickerViewController though, right? That one only concerns reading file timestamps and such, which we don't read in ip overrides.

based on the apple's document(https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api), is it required when we are gonna have access to meta data of a file.do we need to have access meta data of a file?

btw it wouldn't hurt to have that, I don't know if it's required for our upcoming log file operations or not.

Copy link
Collaborator Author

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)


ios/MullvadVPN/Supporting Files/PrivacyInfo.xcprivacy line 16 at r1 (raw file):

Previously, mojganii wrote…

based on the apple's document(https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api), is it required when we are gonna have access to meta data of a file.do we need to have access meta data of a file?

btw it wouldn't hurt to have that, I don't know if it's required for our upcoming log file operations or not.

I'll add it.

@mojganii mojganii force-pushed the backport-changes-to-the-manifest-from-the-release-branch-ios-595 branch from 02d99a8 to 64621c1 Compare April 12, 2024 14:08
@buggmagnet buggmagnet requested a review from rablador April 12, 2024 14:12
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @mojganii and @rablador)


ios/MullvadVPN/Supporting Files/PrivacyInfo.xcprivacy line 16 at r1 (raw file):
From the docs

Declare this reason to access the [...] directories that the user specifically granted access to, such as using a document picker view controller.

It's not explained in the best terms, but I think that boils down to "If you use DocumentPickerViewController, you have to use this reason.
Because we cannot have more granularity than either full access to documents, or no access to documents AFAICT

Copy link
Collaborator Author

@mojganii mojganii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @buggmagnet and @rablador)


ios/MullvadVPN/Supporting Files/PrivacyInfo.xcprivacy line 16 at r1 (raw file):

Previously, buggmagnet wrote…

From the docs

Declare this reason to access the [...] directories that the user specifically granted access to, such as using a document picker view controller.

It's not explained in the best terms, but I think that boils down to "If you use DocumentPickerViewController, you have to use this reason.
Because we cannot have more granularity than either full access to documents, or no access to documents AFAICT

Done.

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@pinkisemils pinkisemils left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@mojganii mojganii force-pushed the backport-changes-to-the-manifest-from-the-release-branch-ios-595 branch from 64621c1 to f26f315 Compare April 15, 2024 08:27
@buggmagnet buggmagnet merged commit 0eab341 into main Apr 15, 2024
4 checks passed
@buggmagnet buggmagnet deleted the backport-changes-to-the-manifest-from-the-release-branch-ios-595 branch April 15, 2024 08:29
Copy link

🚨 End to end tests failed. Please check the failed workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants