Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update android editorconfig to the latest from ktfmt repository #6163

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Apr 22, 2024

This adds the changes from this commit:
facebook/ktfmt@45e78e2


This change is Reviewable

@Pururun Pururun added the Android Issues related to Android label Apr 22, 2024
@Pururun Pururun requested review from Rawa and albin-mullvad April 22, 2024 08:30
@Pururun Pururun self-assigned this Apr 22, 2024
Copy link
Contributor

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)


-- commits line 2 at r1:
What happened here!? 😆

Code quote:

Update endroid ditorconfig to the latest from ktmfmt repository

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

@Pururun Pururun changed the title Update endroid ditorconfig to the latest from ktmfmt repository Update android editorconfig to the latest from ktmfmt repository Apr 22, 2024
@Pururun Pururun force-pushed the update-editorconfig-file branch from bafa576 to 76087ed Compare April 22, 2024 13:33
Copy link
Contributor Author

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)


-- commits line 2 at r1:

Previously, albin-mullvad wrote…

What happened here!? 😆

Ehm no idea. Fixed.

@Pururun Pururun requested review from albin-mullvad and Rawa April 22, 2024 13:34
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun changed the title Update android editorconfig to the latest from ktmfmt repository Update android editorconfig to the latest from ktfmt repository Apr 23, 2024
@Pururun Pururun force-pushed the update-editorconfig-file branch from 76087ed to f0cca90 Compare April 23, 2024 15:15
@Pururun Pururun merged commit 8a37044 into main Apr 23, 2024
24 checks passed
@Pururun Pururun deleted the update-editorconfig-file branch April 23, 2024 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants