-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Google Play payment API to gRPC #6169
Add Google Play payment API to gRPC #6169
Conversation
dc5ecfe
to
575b2c4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 5 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)
mullvad-jni/src/lib.rs
line 311 at r1 (raw file):
let event_listener = match runtime .block_on(async { spawn_management_interface(command_channel.sender()) })
Not relevant to the PR but this needs to be... improved. Pretty sure it was just a hack to get things to work. 😂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)
mullvad-jni/src/lib.rs
line 311 at r1 (raw file):
Previously, dlon (David Lönnhager) wrote…
Not relevant to the PR but this needs to be... improved. Pretty sure it was just a hack to get things to work. 😂
😂 🤷
AFAICT build errors seem to come from the base branch itself, and not my changes 🤷 |
c651385
to
03152bb
Compare
575b2c4
to
2754c29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Closing this PR - the has been cherry-picked into the base branch! |
This PR exposes the Google Play payment via gRPC 🚀
This change is