Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Play payment API to gRPC #6169

Conversation

MarkusPettersson98
Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 commented Apr 23, 2024

This PR exposes the Google Play payment via gRPC 🚀


This change is Reviewable

Copy link

linear bot commented Apr 23, 2024

@MarkusPettersson98 MarkusPettersson98 marked this pull request as draft April 23, 2024 09:48
@MarkusPettersson98 MarkusPettersson98 force-pushed the add-play-payment-api-to-grpc-des-796 branch 2 times, most recently from dc5ecfe to 575b2c4 Compare April 23, 2024 09:57
Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 5 of 5 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @MarkusPettersson98)


mullvad-jni/src/lib.rs line 311 at r1 (raw file):

        let event_listener = match runtime
            .block_on(async { spawn_management_interface(command_channel.sender()) })

Not relevant to the PR but this needs to be... improved. Pretty sure it was just a hack to get things to work. 😂

@MarkusPettersson98 MarkusPettersson98 marked this pull request as ready for review April 23, 2024 10:30
Copy link
Contributor Author

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)


mullvad-jni/src/lib.rs line 311 at r1 (raw file):

Previously, dlon (David Lönnhager) wrote…

Not relevant to the PR but this needs to be... improved. Pretty sure it was just a hack to get things to work. 😂

😂 🤷 :shipit:

@MarkusPettersson98
Copy link
Contributor Author

AFAICT build errors seem to come from the base branch itself, and not my changes 🤷

@MarkusPettersson98 MarkusPettersson98 force-pushed the add-play-payment-api-to-grpc-des-796 branch from 575b2c4 to 2754c29 Compare April 23, 2024 14:10
Copy link
Member

@dlon dlon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@MarkusPettersson98
Copy link
Contributor Author

Closing this PR - the has been cherry-picked into the base branch! :shipit:

@MarkusPettersson98 MarkusPettersson98 deleted the add-play-payment-api-to-grpc-des-796 branch June 3, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants