Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error state cause for full disk access error #6289

Merged
merged 5 commits into from
May 29, 2024

Conversation

dlon
Copy link
Member

@dlon dlon commented May 28, 2024

Fix: DES-992.

This change is Reviewable

Copy link

linear bot commented May 28, 2024

@dlon dlon requested a review from raksooo May 28, 2024 10:01
Copy link
Member

@raksooo raksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 11 files at r1.
Reviewable status: 3 of 11 files reviewed, all discussions resolved

@dlon dlon requested a review from hulthe May 28, 2024 10:05
@raksooo raksooo force-pushed the add-macos-split-tunneling-gui-des-786 branch from ba4e27e to 62c0398 Compare May 28, 2024 11:01
hulthe
hulthe previously approved these changes May 28, 2024
Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 8 of 11 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon marked this pull request as ready for review May 28, 2024 13:14
@raksooo raksooo force-pushed the add-macos-split-tunneling-gui-des-786 branch from 62c0398 to 58556c0 Compare May 28, 2024 13:41
Base automatically changed from add-macos-split-tunneling-gui-des-786 to main May 28, 2024 13:52
@raksooo raksooo dismissed hulthe’s stale review May 28, 2024 13:52

The base branch was changed.

@dlon dlon force-pushed the macos-add-split-tunnel-error-info branch 2 times, most recently from f7aee5e to e509830 Compare May 28, 2024 13:58
Copy link
Member

@raksooo raksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon force-pushed the macos-add-split-tunnel-error-info branch from 61893bd to 6289b4c Compare May 29, 2024 10:55
@dlon dlon merged commit 596286d into main May 29, 2024
44 of 45 checks passed
@dlon dlon deleted the macos-add-split-tunnel-error-info branch May 29, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants