Show error and troubleshoot dialog when lacking full disk access #6301
Conversation
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Reviewable status:
gui/src/shared/notifications/error.ts line 293 at r1 (raw file):
details: messages.pgettext( 'troubleshoot', 'Failed to enable split tunneling. This is usually caused by the mullvad daemon lacking file system permissions. Fix this by:',
I would remove "usually" here, since we know the exact reason in this case.
raksooo
force-pushed
the
instruct-user-to-enable-full-disk-access-for-the-app-des-966
branch
from
e800157 to
510d69d
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @raksooo)
gui/locales/messages.pot line 1094 at r2 (raw file):
msgctxt "notifications" msgid "Failed to enable split tunneling. Please try again or disable it."
"Try reconnecting"?
raksooo
force-pushed
the
instruct-user-to-enable-full-disk-access-for-the-app-des-966
branch
from
510d69d to
b4d963f
Compare
raksooo
force-pushed
the
instruct-user-to-enable-full-disk-access-for-the-app-des-966
branch
from
b4d963f to
4650984
Compare
There was a problem hiding this comment.
I added a condition that prevents the split tunneling troubleshoot dialog from being available on macOS since the description doesn't apply. Let's see if that error is common enough before spending time on an troubleshoot dialog.
Reviewable status: 7 of 9 files reviewed, all discussions resolved (waiting on @dlon)
gui/locales/messages.pot line 1094 at r2 (raw file):
Previously, dlon (David Lönnhager) wrote…
"Try reconnecting"?
Done. I also replaced "it" with "split tunneling".
There was a problem hiding this comment.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status:
raksooo
deleted the
instruct-user-to-enable-full-disk-access-for-the-app-des-966
branch
Split tunneling on macOS requires the app to have "Full Disk Access". This PR adds an error informing the user when it is off and a troubleshoot dialog with instructions for how to enable it.
This change is