Skip to content

Fix TunnelStateProvider missing dep #6305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented May 31, 2024

Fix an issue where we forgot to introduce DeviceRepository in AppModule resulting in missing dep when using a notification.


This change is Reviewable

Copy link

linear bot commented May 31, 2024

@Rawa Rawa self-assigned this May 31, 2024
@Rawa Rawa added the Android Issues related to Android label May 31, 2024
@Rawa Rawa requested a review from Pururun May 31, 2024 09:14
@Rawa Rawa marked this pull request as ready for review May 31, 2024 09:14
Copy link
Contributor

@Pururun Pururun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Rawa Rawa force-pushed the fix-devicerepository-missing-for-tunnelstateprovider-droid-1032 branch from 1ae9d34 to 883f061 Compare June 3, 2024 12:53
@Rawa Rawa merged commit ae0bd42 into main Jun 3, 2024
7 checks passed
@Rawa Rawa deleted the fix-devicerepository-missing-for-tunnelstateprovider-droid-1032 branch June 3, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants