Add disconnect button to Welcome Screen

[Pururun]

---

This change is 

[linear]

DROID-884 Welcome Screen does not display disconnect button when connected

[albin-mullvad]

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/lib/model/src/main/kotlin/net/mullvad/mullvadvpn/lib/model/TunnelState.kt line 36 at r1 (raw file):

    }

    fun showDisconnectButton(): Boolean =

The only difference from isSecured seem to be actionAfterDisconnect, right? Are we sure these two functions should be the same (in other words skip this one)?

Also, I'm not sure this function in it's current state belongs in the model since the usage is UI specific (in comparison to the other convenience functions).

[Pururun]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

---

android/lib/model/src/main/kotlin/net/mullvad/mullvadvpn/lib/model/TunnelState.kt line 36 at r1 (raw file):

Previously, albin-mullvad wrote…

The only difference from isSecured seem to be actionAfterDisconnect, right? Are we sure these two functions should be the same (in other words skip this one)?

Also, I'm not sure this function in it's current state belongs in the model since the usage is UI specific (in comparison to the other convenience functions).

I checked the desktop app and they do not seems to care about actionAfterDisconnect so I will just use isSecuredinstead.

[Pururun]

Reviewable status: 1 of 6 files reviewed, 1 unresolved discussion (waiting on @albin-mullvad)

---

android/lib/model/src/main/kotlin/net/mullvad/mullvadvpn/lib/model/TunnelState.kt line 36 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

I checked the desktop app and they do not seems to care about actionAfterDisconnect so I will just use isSecuredinstead.

Done

[albin-mullvad]

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

---

android/lib/model/src/main/kotlin/net/mullvad/mullvadvpn/lib/model/TunnelState.kt line 36 at r1 (raw file):

Previously, Pururun (Jonatan Rhodin) wrote…

Done

Great! 👍