Re-enable screenshots for iPad

[niklasberglund]

Re-enable screenshots for iPad, since the iPad specific UI is now gone and screenshot tests should work on iPad again. The changes can be tested by running the iOS create screenshots workflow on this branch.

Also updated configuration so that HAS_TIME_ACCOUNT_NUMBER is properly set and partner API is not used.

---

This change is 

[rablador]

Reviewed 1 of 1 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[rablador]

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[buggmagnet]

Reviewed 1 of 1 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @niklasberglund)

---

ios/MullvadVPNUITests/Pages/Page.swift line 53 at r3 (raw file):

    @discardableResult func tapWhereStatusBarShouldBeToScrollToTopMostPosition() -> Self {
        app.coordinate(withNormalizedOffset: CGVector(dx: 0.75, dy: 0)).tap()

Was there a specific reason for this change ?

[rablador]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)

---

ios/MullvadVPNUITests/Pages/Page.swift line 53 at r3 (raw file):

Previously, buggmagnet wrote…

Was there a specific reason for this change ?

On iPad there's a button in the middle of the nav bar to handle split screen and such. Touching that area on a phone makes the current scroll view scroll to top, but touching the same area results in a click in the button instead. Which fails the test as it cannot proceed. Offsetting the touch a little "misses" the button and yields the result we want. It can probably be considered a hack, but if so the original implementation is as well.

[buggmagnet]

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)

---

ios/MullvadVPNUITests/Pages/Page.swift line 53 at r3 (raw file):

Previously, rablador (Jon Petersson) wrote…

On iPad there's a button in the middle of the nav bar to handle split screen and such. Touching that area on a phone makes the current scroll view scroll to top, but touching the same area results in a click in the button instead. Which fails the test as it cannot proceed. Offsetting the touch a little "misses" the button and yields the result we want. It can probably be considered a hack, but if so the original implementation is as well.

That's totally fine, we should document it though, to make sure our future selves do not forget, because it looks like a magic value from an ignorant observer's point of view.

[buggmagnet]

Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved