Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable screenshots for iPad #6403

Merged
merged 1 commit into from
Jun 27, 2024
Merged

Re-enable screenshots for iPad #6403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/ios-screenshots-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ jobs:
env:
SOURCE_PACKAGES_PATH: .spm
TEST_ACCOUNT: ${{ secrets.IOS_TEST_ACCOUNT_NUMBER }}
PARTNER_API_TOKEN: ${{ secrets.STAGEMOLE_PARTNER_AUTH }}
steps:
- name: Checkout repository
uses: actions/checkout@v3
Expand Down
3 changes: 1 addition & 2 deletions ios/Configurations/UITests.xcconfig.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,7 @@ TEST_DEVICE_IDENTIFIER_UUID =
// PARTNER_API_TOKEN =

// Mullvad accounts used by UI tests
HAS_TIME_ACCOUNT_NUMBER[config=Debug] =
HAS_TIME_ACCOUNT_NUMBER[config=Staging] =
HAS_TIME_ACCOUNT_NUMBER =

// Ad serving domain used when testing ad blocking. Note that we are assuming there's an HTTP server running on the host.
AD_SERVING_DOMAIN = vpnlist.to
Expand Down
3 changes: 2 additions & 1 deletion ios/MullvadVPNUITests/Pages/Page.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@ class Page {
}

@discardableResult func tapWhereStatusBarShouldBeToScrollToTopMostPosition() -> Self {
app.coordinate(withNormalizedOffset: CGVector(dx: 0.5, dy: 0)).tap()
// Tapping but not at center x coordinate because on iPad there's an ellipsis button in the center of the status bar
app.coordinate(withNormalizedOffset: CGVector(dx: 0.75, dy: 0)).tap()
return self
}
}
6 changes: 3 additions & 3 deletions ios/Snapfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ ios_version '17.2'
devices([
"iPhone SE (3rd generation)",
"iPhone 15 Pro",
"iPhone 15 Pro Max"
#"iPad Pro (11-inch) (4th generation)",
#"iPad Pro (12.9-inch) (6th generation)"
"iPhone 15 Pro Max",
"iPad Pro (11-inch) (4th generation)",
"iPad Pro (12.9-inch) (6th generation)"
])

languages([
Expand Down
Loading