-
Notifications
You must be signed in to change notification settings - Fork 382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not warn users about multihop extra latency, add info button instead #6535
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 7 of 8 files at r1, all commit messages.
Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsViewController.swift
line 183 at r1 (raw file):
"MULTIHOP_INFORMATION_TEXT", tableName: "Multihop", value: "This setting increases latency. Use only if needed.",
Is this the final copy?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 8 files reviewed, 1 unresolved discussion (waiting on @acb-mv)
ios/MullvadVPN/View controllers/VPNSettings/VPNSettingsViewController.swift
line 183 at r1 (raw file):
Previously, acb-mv wrote…
Is this the final copy?
It is for now. We can improve it, but we currently don't need to change it, because it's the exact same text we're already showing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 7 of 8 files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
553efc7
to
16936b6
Compare
This PR changes the UI behaviour to remove the alert when enabling multihop, for a less disruptive experience.
Instead, an info button is added next to the setting name that indicates what the option does.
This PR also orders by name the
Pages
UITest subfolder.This change is