Fix crash in request vpn permission

[Pururun]

This crash could occur if create intent in request vpn permission was called while vpn permission was already approved

Fixed by returning true immediately in those cases

---

This change is 

[linear]

DROID-1214 Crash on first connection attempt after installing latest beta

[Rawa]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Pururun)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/util/RequestVpnPermission.kt line 11 at r1 (raw file):

class RequestVpnPermission : ActivityResultContract<Unit, Boolean>() {
    override fun createIntent(context: Context, input: Unit): Intent {
        return VpnService.prepare(context)

This is a bit unclear, return type is Intent but VpnService.prepare(context) can return null right? We should at least do !! to make it clear that we don't expect a null.

[Pururun]

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @Rawa)

---

android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/util/RequestVpnPermission.kt line 11 at r1 (raw file):

Previously, Rawa (David Göransson) wrote…

This is a bit unclear, return type is Intent but VpnService.prepare(context) can return null right? We should at least do !! to make it clear that we don't expect a null.

Done.

[Rawa]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved