Fix crash when focusing remove button in device list screen #6601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albin-mullvad
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
android/app/src/main/kotlin/net/mullvad/mullvadvpn/compose/cell/BaseCell.kt line 77 at r1 (raw file):
modifier .then( if (isRowEnabled) {
Reminder to add a comment regarding the underlying issue to avoid future confusion 🙂
Pururun
force-pushed
the
crash-in-devicelistscreen-on-googletv-droid-1236
branch
from
184189a to
29db209
Compare
albin-mullvad
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
albin-mullvad
approved these changes
Aug 12, 2024
There was a problem hiding this comment.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:
albin-mullvad
force-pushed
the
crash-in-devicelistscreen-on-googletv-droid-1236
branch
from
5cc805d to
84933cb
Compare
albin-mullvad
deleted the
crash-in-devicelistscreen-on-googletv-droid-1236
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is