Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Auto connect lockdown mode title #6630

Conversation

Pururun
Copy link
Contributor

@Pururun Pururun commented Aug 16, 2024

  • Remove string with newline in it since it was not treated properly by the translation script
  • Change the line break strategy so that the title looks better in the Auto-connect screen.
  • Make the title bold as other titles.

This change is Reviewable

@Pururun Pururun added the Android Issues related to Android label Aug 16, 2024
@Pururun Pururun requested a review from albin-mullvad August 16, 2024 07:49
Copy link

linear bot commented Aug 16, 2024

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Pururun Pururun force-pushed the auto-connect-lockdown-mode-title-is-not-translated-droid-1257 branch from 37d7b07 to 225b743 Compare August 16, 2024 11:10
@Pururun
Copy link
Contributor Author

Pururun commented Aug 16, 2024

Restored line height to be as before it was changed to bold.

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@albin-mullvad albin-mullvad force-pushed the auto-connect-lockdown-mode-title-is-not-translated-droid-1257 branch from 225b743 to b6f7850 Compare August 19, 2024 09:23
@albin-mullvad albin-mullvad merged commit 58a811f into main Aug 19, 2024
29 checks passed
@albin-mullvad albin-mullvad deleted the auto-connect-lockdown-mode-title-is-not-translated-droid-1257 branch August 19, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants