-
Notifications
You must be signed in to change notification settings - Fork 386
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store unit test report #6966
Store unit test report #6966
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @niklasberglund)
.github/workflows/ios.yml
line 126 at r1 (raw file):
- name: Archive test report if: always()
Isn't the default behavior to always run unless otherwise specified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)
.github/workflows/ios.yml
line 126 at r1 (raw file):
The default value is success()
so by default steps will only run if all previous steps were successful
You can use the following status check functions as expressions in
if
conditionals. A default status check ofsuccess()
is applied unless you include one of these functions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved
d9671b3
to
8b8a357
Compare
Ah, I have to unfold the Store test report artifact step in the action and there it is - staring me in the face, the link to the report - https://github.com/mullvad/mullvadvpn-app/actions/runs/11434648753/artifacts/2080807526 Are we certain this will not leak any secrets? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @rablador)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All artefacts are also listed in the summary page for a run - https://github.com/mullvad/mullvadvpn-app/actions/runs/11434648753/
But they are a little hidden because the list of warnings above is quite long.
Are we certain this will not leak any secrets?
I'm fairly certain, but would be great if others also have a look at the test results and check if you can see a way we might leak secrets through it.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @rablador)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
8b8a357
to
605ead9
Compare
605ead9
to
ada62c1
Compare
Store Xcode test report as artefact for unit tests in
ios.yml
. Can be tested by running the "iOS app" workflow with this branch https://github.com/mullvad/mullvadvpn-app/actions/workflows/ios.ymlThis change is