Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store unit test report #6966

Conversation

niklasberglund
Copy link
Contributor

@niklasberglund niklasberglund commented Oct 11, 2024

Store Xcode test report as artefact for unit tests in ios.yml. Can be tested by running the "iOS app" workflow with this branch https://github.com/mullvad/mullvadvpn-app/actions/workflows/ios.yml


This change is Reviewable

@niklasberglund niklasberglund added the iOS Issues related to iOS label Oct 11, 2024
@niklasberglund niklasberglund self-assigned this Oct 11, 2024
Copy link

linear bot commented Oct 11, 2024

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @niklasberglund)


.github/workflows/ios.yml line 126 at r1 (raw file):

      - name: Archive test report
        if: always()

Isn't the default behavior to always run unless otherwise specified?

Copy link
Contributor Author

@niklasberglund niklasberglund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rablador)


.github/workflows/ios.yml line 126 at r1 (raw file):
The default value is success() so by default steps will only run if all previous steps were successful

You can use the following status check functions as expressions in if conditionals. A default status check of success() is applied unless you include one of these functions.

https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/evaluate-expressions-in-workflows-and-actions#status-check-functions

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@pinkisemils pinkisemils force-pushed the add-test-reports-as-artifacts-to-github-unit-test-runs-ios-858 branch from d9671b3 to 8b8a357 Compare October 21, 2024 06:43
@pinkisemils
Copy link
Collaborator

pinkisemils commented Oct 21, 2024

Where can I download the report? I can't find a link on this page - https://github.com/mullvad/mullvadvpn-app/actions/runs/11434648753/job/31808578723?pr=6966
What am I doing wrong? 🙂

Ah, I have to unfold the Store test report artifact step in the action and there it is - staring me in the face, the link to the report - https://github.com/mullvad/mullvadvpn-app/actions/runs/11434648753/artifacts/2080807526

Are we certain this will not leak any secrets?

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @rablador)

Copy link
Contributor Author

@niklasberglund niklasberglund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All artefacts are also listed in the summary page for a run - https://github.com/mullvad/mullvadvpn-app/actions/runs/11434648753/
But they are a little hidden because the list of warnings above is quite long.

Are we certain this will not leak any secrets?
I'm fairly certain, but would be great if others also have a look at the test results and check if you can see a way we might leak secrets through it.

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @rablador)

Copy link
Contributor

@rablador rablador left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@niklasberglund niklasberglund force-pushed the add-test-reports-as-artifacts-to-github-unit-test-runs-ios-858 branch from 8b8a357 to 605ead9 Compare October 22, 2024 09:18
@pinkisemils pinkisemils force-pushed the add-test-reports-as-artifacts-to-github-unit-test-runs-ios-858 branch from 605ead9 to ada62c1 Compare October 23, 2024 08:33
@pinkisemils pinkisemils merged commit 53778b5 into main Oct 23, 2024
11 checks passed
@pinkisemils pinkisemils deleted the add-test-reports-as-artifacts-to-github-unit-test-runs-ios-858 branch October 23, 2024 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants