Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add http1 feature to hyper-util #7032

Merged

Conversation

Serock3
Copy link
Contributor

@Serock3 Serock3 commented Oct 21, 2024

Fixes crash when legacy hyper client tries to use http1, by enabling the feature in hyper-util.

Normally. we promote http1.1 connections to http2 using Application-Layer Protocol Negotiation (ALPN). This behavior seems to not be reliable, as seen in this test run
https://github.com/mullvad/mullvadvpn-app/actions/runs/11438592659/job/31820684203

which paniced with the following error message:

thread 'tokio-runtime-worker' panicked at /Users/mullemullvad/.cargo/registry/src/index.crates.io-6f17d22bba15001f/hyper-util-0.1.9/src/client/legacy/client.rs:607:37:
http1 feature is not enabled
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
/Users/mullemullvad/actions-runner/_work/mullvadvpn-app/mullvadvpn-app/ios/MullvadVPNUITests/Networking/MullvadAPIWrapper.swift:114: error: -[MullvadVPNUITests.AccountTests testCreateAccount] : failed - Failed to delete account with error: The operation couldn’t be completed. (MullvadVPNUITests.ApiError error 1.)

Passing test run: https://github.com/mullvad/mullvadvpn-app/actions/runs/11440284762


This change is Reviewable

@Serock3 Serock3 added the iOS Issues related to iOS label Oct 21, 2024
Copy link

linear bot commented Oct 21, 2024

@Serock3 Serock3 self-assigned this Oct 21, 2024
@Serock3 Serock3 requested a review from buggmagnet October 21, 2024 15:05
Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@Serock3 Serock3 force-pushed the panic-due-to-missing-http1-feature-in-mullvad-api-crate-ios-891 branch 2 times, most recently from 37570a8 to 6779300 Compare October 22, 2024 07:53
@Serock3 Serock3 force-pushed the panic-due-to-missing-http1-feature-in-mullvad-api-crate-ios-891 branch from 6779300 to 5d921e3 Compare October 22, 2024 08:59
@Serock3 Serock3 merged commit 4419f46 into main Oct 22, 2024
41 checks passed
@Serock3 Serock3 deleted the panic-due-to-missing-http1-feature-in-mullvad-api-crate-ios-891 branch October 22, 2024 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants