Split cell reuse identifiers to segregate subtitle cells

[acb-mv]

Cells in the settings page would fluctuate on view appearance between subtitle and regular styles. This was due to all cells having the same reuse identifier, despite changelog cells being created with the subtitle style while others had the default style. This change gives changelog cells their own reuse identifier, fixing this.

---

This change is 

[linear]

IOS-1038 On/off label jumps between left and right position in settings view

[rablador]

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved

[acb-mv]

ios/MullvadVPN/View controllers/Settings/SettingsDataSource.swift line 139 at r1 (raw file):

Previously, mojganii wrote…

Since we are using cells with diffrent types and identifier in the table view, maybe we can remove registration here and dequeue that in datasource at makeCell and do changing around CellReuseIdentifiers. reusableViewClass to return UITableViewCell:

Great idea. I'll rename reusableViewClass, though, as it is no longer a class value but an instantiated object. (And given that it is an operation, making it a function rather than a computer variable would make it clearer.)

[acb-mv]

ios/MullvadVPN/View controllers/Settings/SettingsDataSource.swift line 139 at r1 (raw file):

Previously, acb-mv wrote…

Great idea. I'll rename reusableViewClass, though, as it is no longer a class value but an instantiated object. (And given that it is an operation, making it a function rather than a computer variable would make it clearer.)

Done

[acb-mv]

Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @mojganii and @rablador)

---

ios/MullvadVPN/View controllers/Settings/SettingsDataSource.swift line 139 at r1 (raw file):

Previously, mojganii wrote…

if we are going to use this type of dequeue we should not have registered cells, then we need to remove otherwise it doesn't work :

Done

[rablador]

Reviewed 1 of 2 files at r2, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)

[buggmagnet]

Reviewed 1 of 2 files at r2, 1 of 1 files at r4, 1 of 2 files at r6, all commit messages.
Reviewable status: 1 of 2 files reviewed, 1 unresolved discussion (waiting on @mojganii and @rablador)