Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CPU count configuration to test framework #7586

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

dlon
Copy link
Member

@dlon dlon commented Feb 3, 2025


This change is Reviewable

@dlon dlon force-pushed the test-add-configurable-vcpus branch 2 times, most recently from a1cc067 to bfedbbf Compare February 3, 2025 20:09
@dlon dlon marked this pull request as ready for review February 4, 2025 09:47
@dlon dlon requested a review from hulthe February 4, 2025 09:47
hulthe
hulthe previously approved these changes Feb 4, 2025
Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: , assuming it runs

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dlon)


test/test-manager/src/config/vm.rs line 67 at r1 (raw file):

    #[serde(default)]
    #[arg(long)]
    pub vcpu: Option<usize>,

😭

@dlon dlon force-pushed the test-add-configurable-vcpus branch from 4e98a7b to ea9a26a Compare February 4, 2025 14:48
hulthe
hulthe previously approved these changes Feb 4, 2025
Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon force-pushed the test-add-configurable-vcpus branch from ea9a26a to f84d977 Compare February 4, 2025 14:58
hulthe
hulthe previously approved these changes Feb 4, 2025
Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

hulthe
hulthe previously approved these changes Feb 4, 2025
Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 3 of 3 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon force-pushed the test-add-configurable-vcpus branch from 8b2ca44 to 356366d Compare February 4, 2025 16:00
@dlon dlon force-pushed the test-add-configurable-vcpus branch from 356366d to 7328998 Compare February 4, 2025 16:05
@dlon dlon force-pushed the test-add-configurable-vcpus branch from 7328998 to e350e0a Compare February 4, 2025 16:05
Copy link
Contributor

@hulthe hulthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r7, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@dlon dlon merged commit c17bff3 into main Feb 4, 2025
40 checks passed
@dlon dlon deleted the test-add-configurable-vcpus branch February 4, 2025 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants