-
Notifications
You must be signed in to change notification settings - Fork 385
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve tunnel state test #7615
Conversation
7d73c78
to
6cd1953
Compare
6cd1953
to
fd20134
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for being so slow to respond to this PR! Completely missed it
Reviewed 3 of 3 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
.github/workflows/git-commit-message-style.yml
line 37 at r4 (raw file):
max-subject-line-length: '72' # The action's wordlist is a bit short. Add more accepted verbs additional-verbs: 'tidy, wrap, obfuscate, bias, prohibit, forbid, revert, slim'
Good! I should do this more often too, instead of submitting to the tyranny of the commit style check :shaking-angry-fist:
test/test-manager/src/tests/ui.rs
line 129 at r1 (raw file):
) -> anyhow::Result<()> { // openvpn-tunnel-state.spec precondition: OpenVPN needs to be selected let query = RelayQueryBuilder::new().openvpn().build();
This is going to pick a random OpenVPN relay globally. We should probably either hard-code it to sweden, or try to apply the specific custom list for this that is specified in the config file (the new way we whitelist relays).
1855cd9
to
1508b95
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed all commit messages.
Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @raksooo)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 3 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
1508b95
to
8e721e6
Compare
This PR improves the tunnel state test by:
This change is