Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tunnel state test #7615

Merged
merged 5 commits into from
Feb 14, 2025
Merged

Improve tunnel state test #7615

merged 5 commits into from
Feb 14, 2025

Conversation

raksooo
Copy link
Member

@raksooo raksooo commented Feb 7, 2025

This PR improves the tunnel state test by:

  • Splitting out OpenVPN specific tests to a separate file
  • Removes some redundant OpenVPN tests
  • Better matches the "In" label in the connection panel

This change is Reviewable

@raksooo raksooo force-pushed the improve-tunnel-state-test branch 14 times, most recently from 7d73c78 to 6cd1953 Compare February 13, 2025 13:22
@raksooo raksooo marked this pull request as ready for review February 13, 2025 14:41
@raksooo raksooo requested review from Serock3 and olmoh February 13, 2025 14:42
@raksooo raksooo force-pushed the improve-tunnel-state-test branch from 6cd1953 to fd20134 Compare February 13, 2025 14:43
Copy link
Contributor

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being so slow to respond to this PR! Completely missed it

Reviewed 3 of 3 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion


.github/workflows/git-commit-message-style.yml line 37 at r4 (raw file):

          max-subject-line-length: '72'
          # The action's wordlist is a bit short. Add more accepted verbs
          additional-verbs: 'tidy, wrap, obfuscate, bias, prohibit, forbid, revert, slim'

Good! I should do this more often too, instead of submitting to the tyranny of the commit style check :shaking-angry-fist:


test/test-manager/src/tests/ui.rs line 129 at r1 (raw file):

) -> anyhow::Result<()> {
    // openvpn-tunnel-state.spec precondition: OpenVPN needs to be selected
    let query = RelayQueryBuilder::new().openvpn().build();

This is going to pick a random OpenVPN relay globally. We should probably either hard-code it to sweden, or try to apply the specific custom list for this that is specified in the config file (the new way we whitelist relays).

@raksooo raksooo force-pushed the improve-tunnel-state-test branch from 1855cd9 to 1508b95 Compare February 13, 2025 17:36
Copy link
Member Author

@raksooo raksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r5.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion

Copy link
Member Author

@raksooo raksooo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 3 of 4 files reviewed, 1 unresolved discussion

Copy link
Contributor

@Serock3 Serock3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 3 of 4 files reviewed, all discussions resolved (waiting on @raksooo)

Copy link
Contributor

@MarkusPettersson98 MarkusPettersson98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 3 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, 1 of 1 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@raksooo raksooo force-pushed the improve-tunnel-state-test branch from 1508b95 to 8e721e6 Compare February 14, 2025 15:40
@raksooo raksooo merged commit 083d06d into main Feb 14, 2025
44 checks passed
@raksooo raksooo deleted the improve-tunnel-state-test branch February 14, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants