Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ios-1092 hide notification bar except in tunnel #7696

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Ios-1092 hide notification bar except in tunnel #7696

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ios/MullvadVPN/Containers/Root/RootContainerViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ protocol RootContainment: Sendable {

extension RootContainment {
var prefersNotificationBarHidden: Bool {
false
true
}

var prefersDeviceInfoBarHidden: Bool {
Expand Down
4 changes: 0 additions & 4 deletions ...llvadVPN/View controllers/CreationAccount/Completed/SetupAccountCompletedController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,10 +32,6 @@ class SetupAccountCompletedController: UIViewController, RootContainment {
true
}

var prefersNotificationBarHidden: Bool {
true
}

weak var delegate: SetupAccountCompletedControllerDelegate?

override func viewDidLoad() {
Expand Down
4 changes: 0 additions & 4 deletions ios/MullvadVPN/View controllers/CreationAccount/Welcome/WelcomeViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@ class WelcomeViewController: UIViewController, RootContainment {
false
}

var prefersNotificationBarHidden: Bool {
true
}

var prefersDeviceInfoBarHidden: Bool {
true
}
Expand Down
4 changes: 0 additions & 4 deletions ios/MullvadVPN/View controllers/DeviceList/DeviceManagementViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,6 @@ class DeviceManagementViewController: UIViewController, RootContainment {
false
}

var prefersNotificationBarHidden: Bool {
true
}

override var preferredStatusBarStyle: UIStatusBarStyle {
.lightContent
}
Expand Down
4 changes: 0 additions & 4 deletions ios/MullvadVPN/View controllers/Login/LoginViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,6 @@ class LoginViewController: UIViewController, RootContainment {
contentView.accountInputGroup.satisfiesMinimumTokenLengthRequirement
}

var prefersNotificationBarHidden: Bool {
true
}

var prefersDeviceInfoBarHidden: Bool {
true
}
Expand Down
4 changes: 0 additions & 4 deletions ios/MullvadVPN/View controllers/OutOfTime/OutOfTimeViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,10 +44,6 @@ class OutOfTimeViewController: UIViewController, RootContainment {
false
}

var prefersNotificationBarHidden: Bool {
true
}

init(interactor: OutOfTimeInteractor, errorPresenter: PaymentAlertPresenter) {
self.interactor = interactor

Expand Down
4 changes: 0 additions & 4 deletions ios/MullvadVPN/View controllers/RedeemVoucher/AddCreditSucceededViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,6 @@ class AddCreditSucceededViewController: UIViewController, RootContainment {
true
}

var prefersNotificationBarHidden: Bool {
true
}

weak var delegate: AddCreditSucceededViewControllerDelegate? {
didSet {
dismissButton.setTitle(delegate?.titleForAction(in: self), for: .normal)
Expand Down
4 changes: 0 additions & 4 deletions ios/MullvadVPN/View controllers/RedeemVoucher/RedeemVoucherViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,6 @@ class RedeemVoucherViewController: UIViewController, UINavigationControllerDeleg
true
}

var prefersNotificationBarHidden: Bool {
true
}

// MARK: - Life Cycle

override func viewDidLoad() {
Expand Down
4 changes: 4 additions & 0 deletions ios/MullvadVPN/View controllers/Tunnel/TunnelViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,10 @@ class TunnelViewController: UIViewController, RootContainment {
false
}

var prefersNotificationBarHidden: Bool {
false
}

init(interactor: TunnelViewControllerInteractor) {
self.interactor = interactor

Expand Down
Loading