Add mullvad-problem-report to default workspace members
#7745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlon
approved these changes
Mar 3, 2025
Serock3
force-pushed
the
add-problem-report-to-default-members
branch
from
07d8129 to
b3b4afc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When connecting, a firewall exception is made to the current relay for
mullvad-problem-report.exe. The daemon expects this binary to be located in the same folder as itself, else it fails and enters the error state. As of 379e453,mullvad-problem-reportis no longer built by default (when running e.g.cargo build), so running the local build of the daemon from the target folder will fail unless the problem report tool is manually built prior. We should add it to the workspace default members so it automatically builds again, to improve the developer experience.This change is