Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog for android 2025.1-beta1 #7758

Merged

Conversation

Rawa
Copy link
Contributor

@Rawa Rawa commented Mar 5, 2025


This change is Reviewable

@Rawa Rawa requested a review from albin-mullvad March 5, 2025 12:23
@Rawa Rawa self-assigned this Mar 5, 2025
@Rawa Rawa added the Android Issues related to Android label Mar 5, 2025
@Rawa Rawa requested a review from Copilot March 5, 2025 12:25
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the Android changelog for the 2025.1-beta1 release. The changes include:

  • Updating the version header to "2025.1-beta1".
  • Adding a new "Security" section with two security-related fixes.

Reviewed Changes

File Description
android/CHANGELOG.md Updated version header and added a security section for fixes.

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (1)

android/CHANGELOG.md:26

  • [nitpick] Consider confirming that the version naming convention (including the beta suffix) is consistent with previous entries and internal guidelines.
## [android/2025.1-beta1] - 2025-01-22

Comment on lines 33 to 36
- Minimize calls to re-establish VPN tunnel, since android may leak some traffic during establish.


## [android/2024.10-beta2] - 2024-12-20
Copy link
Preview

Copilot AI Mar 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Consider capitalizing 'android' to 'Android' for consistency within the changelog.

Suggested change
- Minimize calls to re-establish VPN tunnel, since android may leak some traffic during establish.
## [android/2024.10-beta2] - 2024-12-20
- Minimize calls to re-establish VPN tunnel, since Android may leak some traffic during establish.
## [Android/2024.10-beta2] - 2024-12-20

Copilot is powered by AI, so mistakes are possible. Review output carefully before use.

Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Rawa)


-- commits line 3 at r1:
nit: Update changelog for android/2025.1-beta1

Code quote:

Update changelog

android/src/main/play/release-notes/en-US/default.txt line 2 at r1 (raw file):

- Make daemon aware of route changes to prevent sending traffic before routes are up.
- Minimize calls to re-establish VPN tunnel, since android may leak some traffic during establish.

nit: sounds a bit strange, but maybe just me 🤷 I suggest changing to something like while establishing. Also applies to the changelog.

Code quote:

during establish.

android/CHANGELOG.md line 26 at r1 (raw file):

## [Unreleased]

## [android/2025.1-beta1] - 2025-01-22

bump

Code quote:

2025-01-22

@Rawa Rawa force-pushed the update-changelog-for-android-2025.1-beta1 branch from 42fc1ed to 998b82b Compare March 5, 2025 12:34
Copy link
Contributor Author

@Rawa Rawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @albin-mullvad and @copilot-pull-request-reviewer[bot])


android/CHANGELOG.md line 26 at r1 (raw file):

Previously, albin-mullvad wrote…

bump

Done.

Comment on lines 33 to 36
- Minimize calls to re-establish VPN tunnel, since android may leak some traffic during establish.


## [android/2024.10-beta2] - 2024-12-20
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@Rawa Rawa requested a review from albin-mullvad March 5, 2025 12:35
@Rawa Rawa force-pushed the update-changelog-for-android-2025.1-beta1 branch from 998b82b to 39eb49c Compare March 5, 2025 12:38
Copy link
Collaborator

@albin-mullvad albin-mullvad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @copilot-pull-request-reviewer[bot])

@Rawa Rawa merged commit b5bb4df into prepare-android/2025.1 Mar 5, 2025
26 of 27 checks passed
@Rawa Rawa deleted the update-changelog-for-android-2025.1-beta1 branch March 5, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Android Issues related to Android
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants