-
Notifications
You must be signed in to change notification settings - Fork 381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update changelog for android 2025.1-beta1 #7758
Update changelog for android 2025.1-beta1 #7758
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR updates the Android changelog for the 2025.1-beta1 release. The changes include:
- Updating the version header to "2025.1-beta1".
- Adding a new "Security" section with two security-related fixes.
Reviewed Changes
File | Description |
---|---|
android/CHANGELOG.md | Updated version header and added a security section for fixes. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
android/CHANGELOG.md:26
- [nitpick] Consider confirming that the version naming convention (including the beta suffix) is consistent with previous entries and internal guidelines.
## [android/2025.1-beta1] - 2025-01-22
android/CHANGELOG.md
Outdated
- Minimize calls to re-establish VPN tunnel, since android may leak some traffic during establish. | ||
|
||
|
||
## [android/2024.10-beta2] - 2024-12-20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider capitalizing 'android' to 'Android' for consistency within the changelog.
- Minimize calls to re-establish VPN tunnel, since android may leak some traffic during establish. | |
## [android/2024.10-beta2] - 2024-12-20 | |
- Minimize calls to re-establish VPN tunnel, since Android may leak some traffic during establish. | |
## [Android/2024.10-beta2] - 2024-12-20 |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Rawa)
-- commits
line 3 at r1:
nit: Update changelog for android/2025.1-beta1
Code quote:
Update changelog
android/src/main/play/release-notes/en-US/default.txt
line 2 at r1 (raw file):
- Make daemon aware of route changes to prevent sending traffic before routes are up. - Minimize calls to re-establish VPN tunnel, since android may leak some traffic during establish.
nit: sounds a bit strange, but maybe just me 🤷 I suggest changing to something like while establishing
. Also applies to the changelog.
Code quote:
during establish.
android/CHANGELOG.md
line 26 at r1 (raw file):
## [Unreleased] ## [android/2025.1-beta1] - 2025-01-22
bump
Code quote:
2025-01-22
42fc1ed
to
998b82b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @albin-mullvad and @copilot-pull-request-reviewer[bot])
android/CHANGELOG.md
line 26 at r1 (raw file):
Previously, albin-mullvad wrote…
bump
Done.
android/CHANGELOG.md
Outdated
- Minimize calls to re-establish VPN tunnel, since android may leak some traffic during establish. | ||
|
||
|
||
## [android/2024.10-beta2] - 2024-12-20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
998b82b
to
39eb49c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @copilot-pull-request-reviewer[bot])
This change is